-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The smallest number of schema changes required to support transports extensibility #177
base: v1.2-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I've offered some slightly more long-winded descriptions and a couple of suggested schema tweaks!
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
209e9de
to
416dd2a
Compare
transporttype-response-schema.json must allow vendor defined transports as per https://specs.amwa.tv/nmos-parameter-registers/branches/main/transports "Manufacturers MAY use their own namespaces to indicate transports which are not currently defined within the NMOS namespace." |
"type": "string", | ||
"pattern": "^urn:x-nmos:transport:[a-zA-Z0-9_]+$" | ||
}, | ||
{ | ||
"description": "Any manufacturer-specific transport type URN base defined in the Transports register of the NMOS Parameter Registers", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we expect manufacturer namespaces to be registered in the transports register? I feel this whole area is thin in terms of interoperability. What would a controller be expected to do when it encounters a manufacturer namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume that the controller then check if it knows about this transport and then use the vendor specific schemas about such transport. There may be an issue if multiple vendors claim the same namespace ...
Suggested change Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
This does not include any markdown paragraph yet to introduce the concept of extending supported transports through NMOS Transport Parameters.