Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid for floor plan upload #29

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Grid for floor plan upload #29

merged 1 commit into from
Jun 19, 2023

Conversation

resah
Copy link
Collaborator

@resah resah commented Jun 15, 2023

Description

A grid is initialized together with the map itself, but hidden. When opening the floor plan upload dialog, the grid becomes visible and will be hidden once the dialog closes.

I also had to adjust the icon dimensions to keep the sizes realistic. Since all icon SVGs have some offset in their path definitions, I tried to work around this with expanding the icon in the map (x1.3)

image

Implements: #14

Before submitting the PR, please make sure you do the following

  • Read the Contributing guide
  • Include a description of the changes made in the PR description and in the commit messages.
  • Include screenshots/videos of the changes made.
  • Ensure your changes are covered by tests and verify that the linter and tests are passing, with yarn lint and yarn test.

@resah resah merged commit b23d981 into main Jun 19, 2023
4 checks passed
@resah resah deleted the feat/14-grid branch June 19, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants