Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving HICs to use CMSIS UART Drivers #887

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Moving HICs to use CMSIS UART Drivers #887

wants to merge 9 commits into from

Conversation

mbrossard
Copy link
Contributor

Based on @flit's work on lpc55xx. Using kl27z as an example.

(ping @gerargz, @microbit-carlos)

@mbrossard mbrossard requested a review from flit November 1, 2021 14:33
@mbrossard mbrossard marked this pull request as draft November 1, 2021 14:34
@0Grit
Copy link

0Grit commented Nov 1, 2021

I love the smell of progress.

@tarokajya
Copy link
Contributor

Just quick information. The original lpc55xx/uart.c contains typo around line 109.

    case UART_DATA_BITS_7:
        control |= ARM_USART_DATA_BITS_6;
        break;

ARM_USART_DATA_BITS_6 has to be ARM_USART_DATA_BITS_7, I think.

mbrossard added a commit to mbrossard/DAPLink that referenced this pull request Nov 4, 2021
@mbrossard
Fix a few typos in lpc55xx/uart.c
c384d90 
Some spotted by @tarokajya in ARMmbed#887
@mbrossard mbrossard mentioned this pull request Nov 4, 2021
Merged
@mathias-arm
Copy link
Collaborator

@tarokajya: nice catch, I opened #888 for that (and other) typos.

mbrossard added a commit to mbrossard/DAPLink that referenced this pull request Nov 8, 2021
@mbrossard
Fix a few typos in lpc55xx/uart.c
1b13d69 
Some spotted by @tarokajya in ARMmbed#887
mbrossard added a commit that referenced this pull request Nov 9, 2021
@mbrossard
Fix a few typos in lpc55xx/uart.c (#888)
2c6f6e0 
Some spotted by @tarokajya in #887
@mbrossard mbrossard force-pushed the feature/shared-cmsis-uart branch 2 times, most recently from 4e213a2 to 704b264 Compare November 9, 2021 06:56
@mbrossard mbrossard force-pushed the feature/shared-cmsis-uart branch 2 times, most recently from 5e697d8 to edde7af Compare January 13, 2022 01:03
gaborcsapo pushed a commit to gaborcsapo/DAPLink that referenced this pull request Jun 29, 2022
@mbrossard @gaborcsapo
Fix a few typos in lpc55xx/uart.c (ARMmbed#888)
07d9de2 
Some spotted by @tarokajya in ARMmbed#887
gaborcsapo pushed a commit to gaborcsapo/DAPLink that referenced this pull request Jun 29, 2022
@mbrossard @gaborcsapo
Fix a few typos in lpc55xx/uart.c (ARMmbed#888)
45971c2 
Some spotted by @tarokajya in ARMmbed#887
gaborcsapo pushed a commit to gaborcsapo/DAPLink that referenced this pull request Jun 29, 2022
@mbrossard @gaborcsapo
Fix a few typos in lpc55xx/uart.c (ARMmbed#888)
2c7e3b2 
Some spotted by @tarokajya in ARMmbed#887
@mbrossard mbrossard force-pushed the feature/shared-cmsis-uart branch 3 times, most recently from abe338d to 133d0d0 Compare February 15, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flit flit Awaiting requested review from flit

Assignees
No one assigned
Labels
enhancement hic in progress needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbrossard @0Grit @tarokajya @mathias-arm