Add CMake option for explicitly link library to trusted_storage #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Patater, please review. @simonqhughes, FYI. |
option name: LINK_WITH_TRUSTED_STORAGE default value: ON
Patater
suggested changes
Jul 24, 2019
Patater
added
enhancement
Patater
removed
needs: ci
Patater
removed
the
needs: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake option name: LINK_WITH_TRUSTED_STORAGE
Default value is
ONsince the default of mbedtls forMBEDTLS_PSA_ITS_FILE_Cis using ITS.This PR is based on #180 with the addition of one commit. Please merge after it.
The new option assumes
trusted_storagelibrary exist and forcembedcryptolibrary to link with it. Any application/test uses emulated ITS (by definingMBEDTLS_PSA_ITS_FILE_C) should set this option toOFF.