fm_agent: Wait for fastmodel subprocess to terminate when resetting or terminating it #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the Thread and Queue used by launch_FVP_IRIS * Adds a new telnet_ports property to FastmodelAgent so users can connect to the other terminals Signed-off-by: Chris Swinchatt <christopher.swinchatt@arm.com>
chrisswinchatt-arm
force-pushed
the
feature/wait
branch
from
e465e25 to
bac4926
Compare
…r terminating it Releasing the model via IRIS does not reliably kill the subprocess This gives the FVP up to 3 seconds to terminate gracefully, then force kills it Signed-off-by: Chris Swinchatt <christopher.swinchatt@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing the model via IRIS does not reliably kill the subprocess
This gives the FVP up to 3 seconds to terminate gracefully, then force kills it
It also uses atexit to ensure del is called as Python does not guarantee this
Signed-off-by: Chris Swinchatt christopher.swinchatt@arm.com