-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torch Dataset #62
Torch Dataset #62
Conversation
… if download is set to false
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 97.71% 98.38% +0.67%
==========================================
Files 26 26
Lines 919 991 +72
==========================================
+ Hits 898 975 +77
+ Misses 21 16 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR reduces the test coverage. Is it possible to test the three missing lines?
I think it might be meaningful to showcase the examples in the README.md or at least mention the, so that a new user can find them easily
tests/data/test_data/dataset/test/152144-calibration-properties.json
Outdated
Show resolved
Hide resolved
tests/data/test_data/dataset/test/194228-calibration-properties.json
Outdated
Show resolved
Hide resolved
tests/data/test_data/dataset/test/203718-calibration-properties.json
Outdated
Show resolved
Hide resolved
tests/data/test_data/dataset/test/215701-calibration-properties.json
Outdated
Show resolved
Hide resolved
tests/data/test_data/dataset/train/137608-calibration-properties.json
Outdated
Show resolved
Hide resolved
I have addressed all comments and either made comments explaining why I don't plan on making the change or made the change directly and resolved the conversation. The coverage issue has been resolved by excluding certain lines (i.e. download functions) from the coverage and including an additional test to verify the string representation. I have also completely reworked the |
Description
This PR includes a
torch.Datset
for Calibration Items from thePAINT
database. This includes:root_dir
containing calibration items.csv
file containing information on the splits.To enable minimal tests, some data files (images and JSONs) have been uploaded into Git.
This PR therefore, closes Issue #10.
In addition, unused variables were renamed to clear up any confusion from Issue #59.
NOTE: Due to download functions in the dataset that are not tested, this PR will decrease code coverage!
Type of change
Checklist: