[DRAFT] Remove setup.{cfg,py} and add pyproject.toml #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #764 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 21 21
Lines 2351 2351
=======================================
Hits 2015 2015
Misses 336 336 |
|
Merging. Tested on several OS and it seemingly installs correctly. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
Removes the setup.py script in favour of a flit-based pyproject.toml 0176b15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose flit as a build-system over setuptools because it automatically includes
pelita.__version__as the version number of the package. Flit also apparently includes all files in the repo in the sdist automatically, so there is less configuration needed.If anyone opines for a more featureful build system, I am happy to have a discussion.