Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systematic error testing #765

Merged
merged 15 commits into from
Aug 29, 2023
Merged

Conversation

Debilski
Copy link
Member

Moving some of the test files to external Python files and modules (instead of creating them on the fly in a temporary folder) to allow for easier testing on the CLI.

Fixed the problem when in the UI only errors during loading would be shown. We now also show the reason for an error during the game itself.

Unfortunately, testing for error strings is difficult as this changes between Python versions. All in all, we will need to improve the way we do error handling.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Merging #765 (d1c6abb) into main (0176b15) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
+ Coverage   85.70%   85.85%   +0.14%     
==========================================
  Files          21       21              
  Lines        2351     2354       +3     
==========================================
+ Hits         2015     2021       +6     
+ Misses        336      333       -3     
Files Changed Coverage Δ
pelita/game.py 86.50% <100.00%> (+0.03%) ⬆️
pelita/network.py 59.79% <100.00%> (+1.98%) ⬆️
pelita/team.py 92.76% <100.00%> (ø)

@Debilski Debilski force-pushed the feature/better-failure-messages branch 2 times, most recently from cbe15d7 to a48a915 Compare August 26, 2023 21:45
@Debilski Debilski force-pushed the feature/better-failure-messages branch from a48a915 to 9b988c6 Compare August 26, 2023 23:31
@Debilski Debilski force-pushed the feature/better-failure-messages branch 2 times, most recently from ce8bf41 to 37e83a0 Compare August 29, 2023 07:05
@Debilski Debilski marked this pull request as ready for review August 29, 2023 07:09
@Debilski Debilski force-pushed the feature/better-failure-messages branch from 37e83a0 to d1636d7 Compare August 29, 2023 07:13
@Debilski Debilski merged commit 7fa6203 into ASPP:main Aug 29, 2023
15 checks passed
@Debilski Debilski deleted the feature/better-failure-messages branch August 29, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants