Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDS-1909: fix(app-webdir-ui): changed mailto and phone number aria-label #1411

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

juanmitriatti
Copy link
Contributor

UDS-1909

Changed mailto and phone number aria-label

Description

Links

FOR APPROVERS

@juanmitriatti juanmitriatti requested a review from a team as a code owner December 2, 2024 19:37
@@ -89,7 +89,7 @@ const ProfileCard = ({ ...props }) => {
<a
onClick={() => sendEvent(props.email)}
href={`mailto:${props.email.toLowerCase()}`}
aria-label="Email user"
aria-label={`Mail to :${props.email.toLowerCase()}`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are no longer casting email addresses to lower case. Can you remove the .toLowerCase() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants