Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: #settings > div.tab-nav #15964

Closed
wants to merge 1 commit into from

Conversation

bluelovers
Copy link
Contributor

Description

  • a simple description of what you're trying to accomplish
  • a summary of changes in code
  • which issues it fixes, if any

Screenshots/videos:

image

image

Checklist:

@w-e-w
Copy link
Collaborator

w-e-w commented Jun 7, 2024

please write descriptions not just screenshot with boxes
I wasn't able to know what this does until I try to code


my opinion is I don't like this
this essentially causes the settings navigation bar to have its individual scrool section

this it's advantage is also it's downside
currently if one wish to scroll down the settings navigation you have to scroll down entire settings page

with this PR one I can scroll down these navigation section specifically, without schooling down the settings page

but this also means that one has to scroll down in navigation section specifically
I have to deliberately move my cursor onto the navigation bar in order to scroll down as opposed to just able to scroll down anywhere on the page less convenient in my opinion

there's also an issue that the height of the navigation section change when setting section is switch, the height is determined by either the web page window hight or the height of the current selected category whichever is larger

the end result is that if I switch to a different category the size of the navigation suction would change which is rather disorientating
and if the nav lenght is larget then window height it's actually harder to use


TL;DR
in my opinion this over complicated design reducing usability

@AUTOMATIC1111
Copy link
Owner

AUTOMATIC1111 commented Jun 8, 2024

I have played with those changes and also didn't find them appealing. Any feedback from other users?

@bluelovers
Copy link
Contributor Author

bluelovers commented Jun 8, 2024

image

@AUTOMATIC1111
Copy link
Owner

reopen if there's more

@bluelovers bluelovers deleted the patch-7 branch July 7, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants