Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only apply the index to the specified field #16107

Closed

Conversation

bluelovers
Copy link
Contributor

fix for this pr #15460

Only apply the index to the specified field to avoid causing other plugins to fail to save list values.

Description

  • a simple description of what you're trying to accomplish
  • a summary of changes in code
  • which issues it fixes, if any

Screenshots/videos:

Checklist:

fix for this pr AUTOMATIC1111#15460

Only apply the index to the specified field to avoid causing other plugins to fail to save list values.
Copy link
Collaborator

@w-e-w w-e-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python list is not and has never been support by the infotext syntax

any extension that passes a raw list is doing it wrong
as a python list is not able to be parse back into info by webui

more detailed explanation here

@bluelovers
Copy link
Contributor Author

python list is not and has never been support by the infotext syntax

any extension that passes a raw list is doing it wrong
as a python list is not able to be parse back into info by webui

more detailed explanation here

#15951

@bluelovers
Copy link
Contributor Author

image

好奇一下 是有特殊語法 還是什麼東西幫你把連結變成你這種顯示方式?

@w-e-w
Copy link
Collaborator

w-e-w commented Jun 30, 2024

GitHub連結前面加個 - * 或 數字便編號 1.

- #15460
* https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/15460
1. https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/15460#issuecomment-2195877959
  1. create_infotext allow index and callable, re-work Hires prompt infotext #15460 (comment)

挺方便的小技巧

@AUTOMATIC1111
Copy link
Owner

As wew says, the intention of lists in those parameters is to provide a single value depending on index of iteration/batch. If an extension wants to just list stuff in infotext, it needs to convert that stuff to string. I'll close this PR, and if you want to talk more, you can reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants