Prevent Redundant Live-Preview #16709
Draft
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple Description: Currently, the condition of whether to generate a preview is solely based on the current step count. Depending on the settings (ie.
show_progress_every_n_steps
andlive_preview_refresh_period
) and parameters (ie.steps
), you may waste resources generating an extra preview that you would never be able to see anyway.Summary of Changes: Add a new condition to check if the remaining steps is larger than
show_progress_every_n_steps
stillChecklist