Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG and APP parameters #343

Merged
merged 13 commits into from
Nov 14, 2023

Conversation

Originalidk
Copy link

No description provided.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e72bbd) 81.35% compared to head (9d2f0f8) 81.35%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #343   +/-   ##
=========================================
  Coverage     81.35%   81.35%           
  Complexity     1483     1483           
=========================================
  Files           190      190           
  Lines          4709     4709           
  Branches        513      513           
=========================================
  Hits           3831     3831           
  Misses          723      723           
  Partials        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Originalidk Originalidk self-assigned this Nov 14, 2023
@Originalidk Originalidk added this to the v1.4 milestone Nov 14, 2023
Copy link

@wesho1107 wesho1107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches! LGTM

Copy link

@raydenlim raydenlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than 1 issue, LGTM!

@@ -1463,12 +1463,12 @@ Format: `createconsult d/DATE tt/TIME n/STUDENT_NAME…`
#### 📝️Adding Students to a Consultation: `addtoconsult`
You can add your student(s) into a consultation slot if you need to track students in your consultations.

Format: `addtoconsult CONSULTATION_INDEX n/STUDENT_NAME…`
Format: `addtoconsult CONSULTATION_INDEX [n/NAME]…`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

names optioal?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed!

@Originalidk Originalidk merged commit e4bc9a8 into AY2324S1-CS2103T-T15-1:master Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants