Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG on introduction and command 'add' #13

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

wanghejin
Copy link

Updated the 'welcome message', 'table of contents', 'about this guide' sections of the UG. Laid out a rough structure of the UG in the table of contents section based on CS2101 Revisiting UG slides. Updated the add command section for the first user story.

@wanghejin wanghejin added type.Story A user story type.Doc Documentation labels Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #13 (4c4919b) into master (8f275ad) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30           

@wanghejin wanghejin linked an issue Oct 4, 2023 that may be closed by this pull request
Copy link

@tanyyyming tanyyyming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines -75 to +109
### Adding a person: `add`
### Adding a musician contact: `add`

Adds a person to the address book.
Adds a musician to the contact book. Name, phone number and email can be recorded.

Format: `add n/NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS [t/TAG]…​`
**Format:** `add n/NAME p/PHONE_NUMBER e/EMAIL`

<div markdown="span" class="alert alert-primary">:bulb: **Tip:**
A person can have any number of tags (including 0)
</div>
**Examples:**
* `add n/John Doe p/98928479 e/johndpiano@xmail.com`
* `add n/Betsy Crowe e/violinistbetsy@smtp.com p/87988039`

Examples:
* `add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01`
* `add n/Betsy Crowe t/friend e/betsycrowe@example.com a/Newgate Prison p/1234567 t/criminal`
**Upon success:**

You will see a message indicating successful addition of the musician like below:
[insert image]

**Upon failure:**

Should you input a musician which is already in your contact book(ie. have the same phone number or email as an existing contact), you will see a message like below, please input a different phone/email for the current contact or modify the original contact's relevant details.

[insert image]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice formatting skeleton!

Copy link

@shuyangk shuyangk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanyyyming tanyyyming merged commit 66faa5c into AY2324S1-CS2103T-W11-3:master Oct 5, 2023
5 checks passed
@tanyyyming tanyyyming removed a link to an issue Oct 5, 2023
@wanghejin wanghejin added this to the v1.1 milestone Oct 6, 2023
@wanghejin wanghejin self-assigned this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Doc Documentation type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants