Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Yang Yi's PPP #223

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Update Yang Yi's PPP #223

merged 3 commits into from
Nov 13, 2023

Conversation

yytan25
Copy link

@yytan25 yytan25 commented Nov 13, 2023 •
edited
Loading

Todo:

  • Add GitHub links for enhancements and contributions
  • Edit contributions for UG and DG

@yytan25 yytan25 added the type.Doc Documentation label Nov 13, 2023
@yytan25 yytan25 added this to the v1.4 milestone Nov 13, 2023
@yytan25 yytan25 self-assigned this Nov 13, 2023
@yytan25 yytan25 linked an issue Nov 13, 2023 that may be closed by this pull request
Update Yang Yi's PPP #220
Closed
@yytan25 yytan25 marked this pull request as draft November 13, 2023 05:28
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Merging #223 (4a6b8b8) into master (969e68c) will not change coverage.
Report is 11 commits behind head on master.
The diff coverage is n/a.

❗ Current head 4a6b8b8 differs from pull request most recent head cba5b40. Consider uploading reports for the commit cba5b40 to get more accurate results

@@            Coverage Diff            @@
##             master     #223   +/-   ##
=========================================
  Coverage     77.24%   77.24%           
  Complexity      669      669           
=========================================
  Files           102      102           
  Lines          2118     2118           
  Branches        230      230           
=========================================
  Hits           1636     1636           
  Misses          411      411           
  Partials         71       71

@yytan25 yytan25 marked this pull request as ready for review November 13, 2023 10:58
tanyyyming
tanyyyming approved these changes Nov 13, 2023
View reviewed changes
Copy link

@tanyyyming tanyyyming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tanyyyming tanyyyming merged commit d4bcc4b into AY2324S1-CS2103T-W11-3:master Nov 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyyyming tanyyyming tanyyyming approved these changes

Assignees

@yytan25 yytan25

Labels
type.Doc Documentation
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Update Yang Yi's PPP
2 participants
@yytan25 @tanyyyming