Add DG manual testing for Add and Edit musician #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltonCheng
changed the title
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
=========================================
Coverage 77.24% 77.24%
Complexity 669 669
=========================================
Files 102 102
Lines 2118 2118
Branches 230 230
=========================================
Hits 1636 1636
Misses 411 411
Partials 71 71 |
yytan25
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Apart from the minor issues that I found, LGTM.
Also, as @tanyyyming mentioned, you may wish to reduce the number of test cases, as there is some overlap with what's already mentioned in the UG.
| 1. Test case: `add n/Alexis Tan p/98766789 e/AlexisT@music.com g/gazz` | ||
| **Expected:** Error message saying instrument should be a valid genre name and to use `tags` function for the list of valid genres. | ||
|
|
||
| 5. Adding a duplicate musician |
| **Expected:** Error message saying instrument should be a valid genre name and to use `tags` function for the list of valid genres. | ||
|
|
||
| 5. Adding a duplicate musician | ||
| **Prerequisite:** Ensure that you have completed the first test (Adding a musician with only compulsory fields). |
There was a problem hiding this comment.
If possible, maybe you can insert a link to the test case to reduce ambiguity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added manual testing for Add and Edit Musician.
Do let me know if I missed out anything! :)