Update EditCommand.java and Person.java #81
Merged
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include new method isSameDateTime to check if other person has the same datetime
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
============================================
- Coverage 72.49% 72.39% -0.11%
- Complexity 531 534 +3
============================================
Files 83 83
Lines 1818 1822 +4
Branches 189 191 +2
============================================
+ Hits 1318 1319 +1
- Misses 457 458 +1
- Partials 43 45 +2 ☔ View full report in Codecov by Sentry. |
zoebelle-pang
approved these changes
Apr 3, 2024
| @@ -99,7 +99,7 @@ public CommandResult execute(Model model) throws CommandException { | |||
| throw new CommandException(MESSAGE_DUPLICATE_PERSON); | |||
| } | |||
|
|
|||
| if (model.hasDateTime(editedPerson)) { | |||
| if (!personToEdit.isSameDateTime(editedPerson) && model.hasDateTime(editedPerson)) { | |||
| /** | ||
| * Returns true if both persons have the same set of datetime. | ||
| */ | ||
| public boolean isSameDateTime(Person otherPerson) { |
There was a problem hiding this comment.
Nice addition of this method, Logic is well handled. Good job!
zoebelle-pang
merged commit 48d74e5
into
AY2324S2-CS2103-F15-2:master
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a bug where not editing datetime will cause the edit function to stop working properly.