Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <kind>_<action> method to handle callback #566

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Add <kind>_<action> method to handle callback #566

wants to merge 3 commits into from

Conversation

heka1024
Copy link
Contributor

I think

before_execute :some_callback

is much more nice API than below.

set_callback :execute, :before, :some_callback

So, I add helper method to provide similar interface in ActiveRecord like after_commit, before_validation.

@heka1024 heka1024 changed the base branch from main to next September 29, 2023 18:31
@heka1024
Copy link
Contributor Author

@AaronLasseigne Could you please take a look? Your feedback is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattEhrlich MattEhrlich MattEhrlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heka1024 @MattEhrlich