Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub authentication #110

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Add GitHub authentication #110

merged 6 commits into from
Jun 4, 2024

Conversation

GDWR
Copy link
Contributor

@GDWR GDWR commented Jun 4, 2024

Adds back GitHub authentication, mirroring the Discord implementation.
Adds documentation for setting up GitHub OAuth2 application.

@GDWR GDWR requested a review from fisher60 June 4, 2024 18:44
@GDWR
Copy link
Contributor Author

GDWR commented Jun 4, 2024

Closes #95

Copy link
Member

@fisher60 fisher60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small mistake in docstring

abandonauth/routers/ui.py Outdated Show resolved Hide resolved
@fisher60 fisher60 self-requested a review June 4, 2024 18:58
Copy link
Member

@fisher60 fisher60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fisher60 fisher60 merged commit 7529bf7 into main Jun 4, 2024
2 checks passed
@fisher60 fisher60 deleted the GDWR/github branch June 4, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants