Skip to content

Commit

Permalink
testing: Fix tests passing when test commands fail (#1733)
Browse files Browse the repository at this point in the history
PR #1563 accidentally changed tests to accept failing commands by
default. (This seems to have been a mistake -- a temporary change
added when debugging that LG neglected to remove before submitting
the PR.)

This can cause tests to pass even though the program crashed, when
a previous run created the correct output file.

---------

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
  • Loading branch information
brechtvl authored Sep 28, 2023
1 parent baca4c2 commit 0210c88
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions src/build-scripts/nosanitize.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Small leaks that make CI fail, suppress until cause is identified.
leak:__cxa_thread_atexit
leak:std::string::_Rep::_S_create
2 changes: 1 addition & 1 deletion src/testrender/testrender.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ main(int argc, const char* argv[])

// We're done with the shading system now, destroy it
rend->clear();
delete shadingsys;
delete rend;
delete shadingsys;
return EXIT_SUCCESS;
}
2 changes: 1 addition & 1 deletion testsuite/runtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def make_relpath (path, start=os.curdir):
outputs = [ "out.txt" ] # default

# Control image differencing
failureok = 1
failureok = 0
failthresh = 0.004
hardfail = 0.01
failpercent = 0.02
Expand Down

0 comments on commit 0210c88

Please sign in to comment.