Support archive_unstable_body #864
Conversation
packages/e2e/src/chain.test.ts
Outdated
| @@ -42,6 +42,13 @@ describe('chain rpc', () => { | |||
| await check(api.rpc.chain.getBlock(hash0)).toMatchSnapshot() | |||
| await check(api.rpc.chain.getBlock(hash1000)).toMatchSnapshot() | |||
|
|
|||
| expect(await api.rpc('archive_unstable_body', hash1000)).toEqual( | |||
| expect.arrayContaining([ | |||
| '0x280401000be3da72cc7d01', | |||
There was a problem hiding this comment.
it's most probably not ok to hardcode these. How can I access the lower parts of a snapshot?
There was a problem hiding this comment.
It's fine. Block 100 isn't going to change
There was a problem hiding this comment.
any reason to not use match snapshot of the whole body?
There was a problem hiding this comment.
the thing is that archive_unstable_body only responds with the extrinsics array. However toMatchSnapshot is for the body, the header etc. So if I could have selected juste the extrinsics from this snaptshot, it would have been ideal.
There was a problem hiding this comment.
maybe you misunderstood how snapshot works. it is for any shapes of data. run yarn vitest -u file/name.ts to generate/update snapshots
https://vitest.dev/guide/snapshot
There was a problem hiding this comment.
thanks, I have indeed no idea, and was definitely looking for help. I'll check it out in the morning.
There was a problem hiding this comment.
Thanks for the guidance, it's now using a snapshot
| * | ||
| * @return Block extrinsics | ||
| */ | ||
| export const archive_unstable_body: Handler<[HexString], HexString[]> = async (context, [hash]) => { |
There was a problem hiding this comment.
Would you like me to create a new archive folder, and put this function there?
There was a problem hiding this comment.
it will make finding things a bit easier
There was a problem hiding this comment.
done, I also moved the archive alias.
closes #860
This adds support for
archive_unstable_bodywhich answers an array of extrinsics.Please let me know what's the best way to test this without hardcoding the extrinsics