Fix loopback address display for IPv6 #866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In IPv6, the loopback address is `::1`, short for `0000:0000:0000:0000:0000:0000:0000:0001`. Before this commit, it was displayed as `::`, which is short for `0000:0000:0000:0000:0000:0000:0000:0000` - not the same addresses.
|
it is displaying the listen address, and in the case it is listening on the unspecified address, it should display as it is? |
|
@xlc this was a misunderstanding on my part - I assumed the behavior should be the same as when it displayed IPv4's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IPv6, the loopback address is
::1, short for0000:0000:0000:0000:0000:0000:0000:0001.Before this commit, it was displayed as
::, which is short for0000:0000:0000:0000:0000:0000:0000:0000- not the same addresses.See RFC 4219 for IPv6.