Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update smoldot to the latest version #867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mittal-parth
Copy link

@mittal-parth mittal-parth commented Dec 13, 2024

Updates smoldot submodule to the latest version using git submodule update --remote vendor/smoldot

Closes #848

@xlc
Copy link
Member

xlc commented Dec 14, 2024

please also fix CI

@mittal-parth
Copy link
Author

mittal-parth commented Dec 18, 2024

Hi @xlc
Two ways to fix the CI here:

  1. Update the rust version as the CI is complaining:
error: package `wasmi_core v0.40.0` cannot be built because it requires rustc 1.80 or newer, while the currently active rustc version is 1.77.2
Either upgrade to rustc 1.80 or newer, or use
cargo update wasmi_core@0.40.0 --precise ver
where `ver` is the latest version of `wasmi_core` supporting rustc 1.77.2
  1. I did a cargo update in executor dir and inside all the vendor/smoldot/ dirs that had a cargo.toml. This fixes everything but that would make the submodule commit a dirty one.

Which one should we go for?

Thanks!

@xlc
Copy link
Member

xlc commented Dec 18, 2024

Please update the rust version used in CI
Do cargo update in executor if needed. Do not do it inside vendor/smoldot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update smoldot version to latest
2 participants