Skip to content

Commit

Permalink
#1406: use event.schema during create as fallback and warn user durin…
Browse files Browse the repository at this point in the history
…g update
  • Loading branch information
JoernBerkefeld committed Jul 5, 2024
1 parent a718664 commit 61846cd
Show file tree
Hide file tree
Showing 14 changed files with 213 additions and 54 deletions.
12 changes: 0 additions & 12 deletions @types/lib/metadataTypes/Asset.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,18 +158,6 @@ declare class Asset extends MetadataType {
* @returns {CodeExtractItem} metadata
*/
static postRetrieveTasks(metadata: AssetItem): CodeExtractItem;
/**
* Gets executed after deployment of metadata type
*
* @param {MetadataTypeMap} metadata metadata mapped by their keyField
* @param {MetadataTypeMap} _ originalMetadata to be updated (contains additioanl fields)
* @param {{created: number, updated: number}} createdUpdated counter representing successful creates/updates
* @returns {Promise.<void>} -
*/
static postDeployTasks(metadata: MetadataTypeMap, _: MetadataTypeMap, createdUpdated: {
created: number;
updated: number;
}): Promise<void>;
/**
* helper for {@link Asset.postDeployTasks}. triggers a refresh of active triggerredSendDefinitions associated with the updated asset-message items. Gets executed if refresh option has been set.
*
Expand Down
2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/Asset.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion @types/lib/metadataTypes/DataExtension.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,10 @@ declare class DataExtension extends MetadataType {
* Updates a single dataExtension. Also updates their columns in 'dataExtension.columns'
*
* @param {DataExtensionItem} metadata single metadata entry
* @param {boolean} [handleOutside] if the API reponse is irregular this allows you to handle it outside of this generic method
* @returns {Promise} Promise
*/
static update(metadata: DataExtensionItem): Promise<any>;
static update(metadata: DataExtensionItem, handleOutside?: boolean): Promise<any>;
/**
* Gets executed after deployment of metadata type
*
Expand Down
2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/DataExtension.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 27 additions & 6 deletions @types/lib/metadataTypes/Event.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export type TemplateMap = import('../../types/mcdev.d.js').TemplateMap;
* @augments MetadataType
*/
declare class Event extends MetadataType {
static reCacheDataExtensions: any[];
/**
* Retrieves Metadata of Event Definition.
* Endpoint /interaction/v1/eventDefinitions return all Event Definitions with all details.
Expand Down Expand Up @@ -92,6 +93,23 @@ declare namespace Event {
keyIsFixed: boolean;
keyField: string;
nameField: string;
/**
* @typedef {import('../../types/mcdev.d.js').BuObject} BuObject
* @typedef {import('../../types/mcdev.d.js').CodeExtract} CodeExtract
* @typedef {import('../../types/mcdev.d.js').CodeExtractItem} CodeExtractItem
* @typedef {import('../../types/mcdev.d.js').MetadataTypeItem} MetadataTypeItem
* @typedef {import('../../types/mcdev.d.js').MetadataTypeItemDiff} MetadataTypeItemDiff
* @typedef {import('../../types/mcdev.d.js').MetadataTypeItemObj} MetadataTypeItemObj
* @typedef {import('../../types/mcdev.d.js').MetadataTypeMap} MetadataTypeMap
* @typedef {import('../../types/mcdev.d.js').MetadataTypeMapObj} MetadataTypeMapObj
* @typedef {import('../../types/mcdev.d.js').SoapRequestParams} SoapRequestParams
* @typedef {import('../../types/mcdev.d.js').TemplateMap} TemplateMap
*/
/**
* Event MetadataType
*
* @augments MetadataType
*/
createdDateField: string;
createdNameField: string;
lastmodDateField: string;
Expand All @@ -105,11 +123,7 @@ declare namespace Event {
validTypes: string[];
fields: {
'arguments.audienceCount': {
isCreateable: boolean; /**
* Event MetadataType
*
* @augments MetadataType
*/
isCreateable: boolean;
isUpdateable: boolean;
retrieving: boolean;
template: boolean;
Expand Down Expand Up @@ -391,7 +405,14 @@ declare namespace Event {
isCreateable: boolean;
isUpdateable: boolean;
retrieving: boolean;
template: boolean;
template: boolean; /**
* Gets executed after deployment of metadata type
*
* @param {MetadataTypeMap} upsertResults metadata mapped by their keyField as returned by update/create
* @param {MetadataTypeMap} originalMetadata metadata to be updated (contains additioanl fields)
* @param {{created: number, updated: number}} createdUpdated counter representing successful creates/updates
* @returns {Promise.<void>} -
*/
};
'metaData.automationData.createdBy.name': {
isCreateable: boolean;
Expand Down
Loading

0 comments on commit 61846cd

Please sign in to comment.