#1406: add retrieve & delete tests for event

Accenture · Jul 5, 2024 · ef66ebb · ef66ebb
1 parent 9bb1b4e
commit ef66ebb
Show file tree

Hide file tree

Showing 13 changed files with 1,026 additions and 23 deletions.
diff --git a/@types/lib/metadataTypes/Event.d.ts b/@types/lib/metadataTypes/Event.d.ts
@@ -293,6 +293,12 @@ declare namespace Event {
  retrieving: boolean;
  template: boolean;
  };
+ 'configurationArguments.unconfigured': {
+ isCreateable: boolean;
+ isUpdateable: boolean;
+ retrieving: boolean;
+ template: boolean;
+ };
  createdBy: {
  isCreateable: boolean;
  isUpdateable: boolean;
@@ -530,6 +536,12 @@ declare namespace Event {
  'metaData.automationData.scheduleObject.createdBy': {
  isCreateable: boolean;
  isUpdateable: boolean;
+ /**
+ * parses retrieved Metadata before saving
+ *
+ * @param {MetadataTypeItem} metadata a single event definition
+ * @returns {MetadataTypeItem} parsed metadata
+ */
  retrieving: boolean;
  template: boolean;
  };
@@ -959,7 +971,7 @@ declare namespace Event {
  retrieving: boolean;
  template: boolean;
  };
- r__dataExtension_CustomerKey: {
+ r__dataExtension_key: {
  isCreateable: boolean;
  isUpdateable: boolean;
  retrieving: boolean;

diff --git a/@types/lib/metadataTypes/Event.d.ts.map b/@types/lib/metadataTypes/Event.d.ts.map
diff --git a/@types/lib/metadataTypes/definitions/Event.definition.d.ts b/@types/lib/metadataTypes/definitions/Event.definition.d.ts
@@ -189,6 +189,12 @@ declare namespace _default {
  retrieving: boolean;
  template: boolean;
  };
+ 'configurationArguments.unconfigured': {
+ isCreateable: boolean;
+ isUpdateable: boolean;
+ retrieving: boolean;
+ template: boolean;
+ };
  createdBy: {
  isCreateable: boolean;
  isUpdateable: boolean;
@@ -855,7 +861,7 @@ declare namespace _default {
  retrieving: boolean;
  template: boolean;
  };
- r__dataExtension_CustomerKey: {
+ r__dataExtension_key: {
  isCreateable: boolean;
  isUpdateable: boolean;
  retrieving: boolean;

diff --git a/lib/metadataTypes/Event.js b/lib/metadataTypes/Event.js
@@ -280,7 +280,12 @@ class Event extends MetadataType {
  'CustomerKey',
  'Name'
  );
- delete metadataItem.schema;
+ if (metadataItem.schema) {
+ delete metadataItem.schema;
+ Util.logger.info(
+ ` - ${this.definition.type} ${metadataItem[this.definition.keyField]}: dataExtension ${metadataItem.r__dataExtension_key} found, ignoring schema-section in ${this.definition.type} json`
+ );
+ }
  }
  } catch {
  // no action

diff --git a/lib/metadataTypes/definitions/Event.definition.js b/lib/metadataTypes/definitions/Event.definition.js
@@ -279,12 +279,12 @@ export default {
  // retrieving: false,
  // template: false,
  // },
- // 'configurationArguments.unconfigured': {
- //  isCreateable: false,
- //  isUpdateable: false,
- //  retrieving: false,
- //  template: false,
- // },
+ 'configurationArguments.unconfigured': {
+ isCreateable: false,
+ isUpdateable: false,
+ retrieving: false,
+ template: false,
+ },
  // 'configurationArguments.version': {
  // isCreateable: false,
  // isUpdateable: false,
@@ -963,7 +963,7 @@ export default {
  retrieving: true,
  template: true,
  },
- r__dataExtension_CustomerKey: {
+ r__dataExtension_key: {
  isCreateable: false,
  isUpdateable: false,
  retrieving: true,

diff --git a/test/general.test.js b/test/general.test.js
@@ -461,7 +461,7 @@ describe('GENERAL', () => {
  );
  assert.equal(
  Object.keys(result[buName]['dataExtension']).length,
- 5,
+ 6,
  'retrieve should have returned 5 dataExtension'
  );
  assert.equal(

diff --git a/test/resources/9999999/dataExtension/retrieve-response.xml b/test/resources/9999999/dataExtension/retrieve-response.xml
@@ -142,6 +142,30 @@
  <RetainUntil />
  <CategoryID>2</CategoryID>
  </Results>
+ <Results xsi:type="DataExtension">
+ <PartnerKey xsi:nil="true" />
+ <CreatedDate>2024-07-05T08:01:54.803</CreatedDate>
+ <ModifiedDate>2024-07-05T08:01:58.923</ModifiedDate>
+ <ObjectID>f2cc2b21-d73a-ef11-a5c8-5cba2c702db8</ObjectID>
+ <CustomerKey>testExisting_event - 2024-07-05T080154625</CustomerKey>
+ <Name>testExisting_event - 2024-07-05T080154625</Name>
+ <Description />
+ <IsSendable>true</IsSendable>
+ <IsTestable>false</IsTestable>
+ <SendableDataExtensionField>
+ <PartnerKey xsi:nil="true" />
+ <ObjectID xsi:nil="true" />
+ <Name>ContactId</Name>
+ </SendableDataExtensionField>
+ <SendableSubscriberField>
+ <Name>_SubscriberKey</Name>
+ </SendableSubscriberField>
+ <RowBasedRetention>false</RowBasedRetention>
+ <ResetRetentionPeriodOnImport>false</ResetRetentionPeriodOnImport>
+ <DeleteAtEndOfRetentionPeriod>false</DeleteAtEndOfRetentionPeriod>
+ <RetainUntil />
+ <CategoryID>2</CategoryID>
+ </Results>
  </RetrieveResponseMsg>
  </soap:Body>
 </soap:Envelope>