Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/984: bulk update notification email addresses #1066

Open
wants to merge 71 commits into
base: develop
Choose a base branch
from
Open

Feature/984: bulk update notification email addresses #1066

wants to merge 71 commits into from

Commits on Aug 1, 2023

  1. #984: setNotifEmailAddr command added

    @phjulia
    phjulia committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b09acd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. #984: added a function to update notifications for Automations

    @phjulia
    phjulia committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    000778e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. #984: move updateNotifications under runMethod

    @phjulia
    phjulia committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    76dda3e View commit details
    Browse the repository at this point in the history

  2. #984: enable updating notes or email addresses, additional checks, mo… 

    …ved repetitive code into a method
    @phjulia
    phjulia committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    49440b9 View commit details
    Browse the repository at this point in the history

  3. #984: added 2 test cases for updateNotifications

    @phjulia
    phjulia committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    10a3fe3 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. #984: updated function name

    @phjulia
    phjulia committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    19f1318 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. #984: updateNotifications improvements

    @phjulia
    phjulia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    24543f0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/984-feature-bulk-update-notificat… 

    …ion-email-addresses
    @phjulia
    phjulia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    581a3a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. #984: fixed tests, adjusted logic to set some notifications, check if… 

    … notifs exist etc
    @phjulia
    phjulia committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    0f1c3fe View commit details
    Browse the repository at this point in the history

  2. #984: fixed tests - +2 api requests because there is a new test autom… 

    …ation
    @phjulia
    phjulia committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    48e37e1 View commit details
    Browse the repository at this point in the history

  3. #984: moved repetitive code into #getEncodedAutomationIDs()

    @phjulia
    phjulia committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    e7c93c2 View commit details
    Browse the repository at this point in the history

  4. #984: added interactive questions, no email validation at this point

    @phjulia
    phjulia committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    92dfd6e View commit details
    Browse the repository at this point in the history

  5. #984: corrected test

    @phjulia
    phjulia committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    9934cbd View commit details
    Browse the repository at this point in the history

  6. #984: remove notifications option

    @phjulia
    phjulia committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    83f679d View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. #984: added email validator

    @phjulia
    phjulia committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ae4cc5d View commit details
    Browse the repository at this point in the history

  2. #984: added a test for importFile

    @phjulia
    phjulia committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    309de98 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. #984: added a test for --clear option

    @phjulia
    phjulia committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    94d8c11 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/984-feature-bulk-update-notificat… 

    …ion-email-addresses
    @phjulia
    phjulia committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    18cd195 View commit details
    Browse the repository at this point in the history

  3. #984: +1 test automations, the rest of the tests were adapted

    @phjulia
    phjulia committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    ceefc04 View commit details
    Browse the repository at this point in the history

  4. #984: --clear option for importFile

    @phjulia
    phjulia committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    127e1e4 View commit details
    Browse the repository at this point in the history

  5. #984: exit updateNotifications for importFile if user provided option… 

    …s that are not available for this type
    @phjulia
    phjulia committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    d87161a View commit details
    Browse the repository at this point in the history

  6. #984: note was not set if email address was not provided

    @phjulia
    phjulia committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    00704bf View commit details
    Browse the repository at this point in the history

  7. #984: retrive for clearNotifications is already covered

    @phjulia
    phjulia committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    3910110 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. #984: some improvements and more tests

    @phjulia
    phjulia committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e8f7744 View commit details
    Browse the repository at this point in the history

  2. #984: ternary -> if

    @phjulia
    phjulia committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    556d256 View commit details
    Browse the repository at this point in the history

  3. #984: removed error variable

    @phjulia
    phjulia committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    1d30d9e View commit details
    Browse the repository at this point in the history

  4. Update test/type.importFile.test.js 

    Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
    @phjulia @JoernBerkefeld
    phjulia and JoernBerkefeld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    051b215 View commit details
    Browse the repository at this point in the history

  5. Update test/type.automation.test.js 

    Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
    @phjulia @JoernBerkefeld
    phjulia and JoernBerkefeld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    9f822f6 View commit details
    Browse the repository at this point in the history

  6. #984: test update completion email address and error email address

    @phjulia
    phjulia committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    720231c View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. #984: +9 positive test cases

    @phjulia
    phjulia committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    739eaf8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/984-feature-bulk-update-notification-email-addr… 

    …esses' of github.com:Accenture/sfmc-devtools into feature/984-feature-bulk-update-notification-email-addresses
    @phjulia
    phjulia committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    10bf762 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. #984: +1 negative test case

    @phjulia
    phjulia committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a38f02b View commit details
    Browse the repository at this point in the history

  2. #984: group:

    @phjulia
    phjulia committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6d87df6 View commit details
    Browse the repository at this point in the history

  3. #984: moved properties out of static variables

    @phjulia
    phjulia committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    eff4b1a View commit details
    Browse the repository at this point in the history

  4. #984: removed static variables

    @phjulia
    phjulia committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    55a3389 View commit details
    Browse the repository at this point in the history

  5. Update lib/cli.js 

    Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
    @phjulia @JoernBerkefeld
    phjulia and JoernBerkefeld committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d07cf91 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. #984: made getKeysToSetNotifications in MetadataType abstract, moved … 

    …method into IMportFile
    @phjulia
    phjulia committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    47c847d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/984-feature-bulk-update-notification-email-addr… 

    …esses' of github.com:Accenture/sfmc-devtools into feature/984-feature-bulk-update-notification-email-addresses
    @phjulia
    phjulia committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    e07fba6 View commit details
    Browse the repository at this point in the history

  3. #984: clearNotifications was removed from MetadataType and index

    @phjulia
    phjulia committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    5bdfa31 View commit details
    Browse the repository at this point in the history

  4. #984: info to verbose

    @phjulia
    phjulia committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    4cc50b3 View commit details
    Browse the repository at this point in the history

  5. #984: renamed negative test cases

    @phjulia
    phjulia committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    592d3fb View commit details
    Browse the repository at this point in the history

  6. #984: renamed negative test cases

    @phjulia
    phjulia committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    989fed4 View commit details
    Browse the repository at this point in the history

  7. #984: renamed test cases

    @phjulia
    phjulia committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    695afb0 View commit details
    Browse the repository at this point in the history

  8. #984: split a test case into 2

    @phjulia
    phjulia committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    fc03b1d View commit details
    Browse the repository at this point in the history

  9. #984: split a test case into 3

    @phjulia
    phjulia committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    729eb96 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. #984: +3 tests for clearNotifications (+3 cached automations, +6 API … 

    …calls)
    @phjulia
    phjulia committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    f691e6c View commit details
    Browse the repository at this point in the history

  2. #984: improved regex email validation

    @phjulia
    phjulia committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    3023492 View commit details
    Browse the repository at this point in the history

  3. #984: moved type specific stuff into child class

    @phjulia
    phjulia committed Aug 27, 2023
    2 Configuration menu
    Copy the full SHA
    9abe1e5 View commit details
    Browse the repository at this point in the history

  4. #984: removed options from updateNotifications command

    @phjulia
    phjulia committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    1609171 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. #984: added a test for updating a note only

    @phjulia
    phjulia committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9bb5be7 View commit details
    Browse the repository at this point in the history

  2. #984: +1 automation

    @phjulia
    phjulia committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0dc51ae View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. #984: added a function to retrieve and deploy that is used for fixKey… 

    …s and updateNotifications
    @phjulia
    phjulia committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    23d0cea View commit details
    Browse the repository at this point in the history

  2. #984: regex for email validation replaced

    @phjulia
    phjulia committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    12f7b3d View commit details
    Browse the repository at this point in the history

  3. #984: add questions to an array

    @phjulia
    phjulia committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    fe22dca View commit details
    Browse the repository at this point in the history

  4. #984: validate added

    @phjulia
    phjulia committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0b43078 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into feature/984-feature-bulk-update-notificat… 

    …ion-email-addresses
    @phjulia
    phjulia committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    6c09a25 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. #984: test cases

    @phjulia
    phjulia committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    9ddbefe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/984-feature-bulk-update-notificat… 

    …ion-email-addresses
    @phjulia
    phjulia committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    f1ff0de View commit details
    Browse the repository at this point in the history

  3. #984: +15 automations/+15 API calls

    @phjulia
    phjulia committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    c18e6ef View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. #984: fixed issue with email validation

    @phjulia
    phjulia committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    7b0de99 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2023

  1. #984: merge develop into branch

    @phjulia
    phjulia committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    1101102 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Merge branch 'develop' into feature/984-feature-bulk-update-notificat… 

    …ion-email-addresses
    @JoernBerkefeld
    JoernBerkefeld committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7fb1fb4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/984-feature-bulk-update-notificat… 

    …ion-email-addresses
    @JoernBerkefeld
    JoernBerkefeld committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    af22fb9 View commit details
    Browse the repository at this point in the history

  3. #0: auto-formatting

    @JoernBerkefeld
    JoernBerkefeld committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    bd755f4 View commit details
    Browse the repository at this point in the history

  4. #984: improve log message for updateNotification

    @JoernBerkefeld
    JoernBerkefeld committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    258c067 View commit details
    Browse the repository at this point in the history

  5. #984: move updateNotification logic from custom createOrUpdate into p… 

    …reDeployTasks
    @JoernBerkefeld
    JoernBerkefeld committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    63f9784 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. #984: rename importFile test for updateNotification

    @JoernBerkefeld
    JoernBerkefeld committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8e2670a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. #984: refactoring

    @JoernBerkefeld
    JoernBerkefeld committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9981086 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Merge branch 'develop' into feature/984-feature-bulk-update-notificat… 

    …ion-email-addresses
    @JoernBerkefeld
    JoernBerkefeld committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    801317d View commit details
    Browse the repository at this point in the history

  2. #0: pre-commit hook logs

    @JoernBerkefeld
    JoernBerkefeld committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f1df201 View commit details
    Browse the repository at this point in the history

  3. #984: fix tests for importFile & query

    @JoernBerkefeld
    JoernBerkefeld committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6626df6 View commit details
    Browse the repository at this point in the history