Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/1397: retrieving journey with %23 handled more gracefully #1426

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jul 8, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.0.4 milestone Jul 8, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 8, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Jul 8, 2024 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Jul 8, 2024
@JoernBerkefeld JoernBerkefeld added the c/journey COMPONENT label Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Coverage Report

Commit:4780d3f
Base: develop@a9c2f93

Type Base This PR
Total Statements Coverage  69.21%  69.2%  (-0.01%)
Total Branches Coverage  67.74%  67.71%  (-0.03%)
Total Functions Coverage  80.85%  80.85%  (+0%)
Total Lines Coverage  69.21%  69.2%  (-0.01%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Journey.js  59.5%  54.36%  84.61%  59.5%

@JoernBerkefeld JoernBerkefeld merged commit 4c24853 into develop Jul 8, 2024
12 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1397-retrieving-journey-by-id-saves-wrong-filename-when-metadata-is-used branch July 8, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/journey COMPONENT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] retrieving journey by id saves wrong filename when --metadata is used
1 participant