Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1443 enhance bt dependencies with ampscriptssjs parsing #1469

Merged
merged 14 commits into from
Jul 22, 2024
Merged

Feature/1443 enhance bt dependencies with ampscriptssjs parsing #1469

merged 14 commits into from
Jul 22, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jul 19, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

important: this solution works fine for local assets but will fail if assets that are dependencies were shared from other BUs to the current

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (TODO)

@JoernBerkefeld JoernBerkefeld added this to the 7.1.0 milestone Jul 19, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 19, 2024
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Jul 19, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Jul 19, 2024 that may be closed by this pull request
[FEATURE] enhance bt --dependencies with ampscript/ssjs parsing #1443
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Coverage Report

Commit:7c81c67
Base: develop@e650e8d

Type Base This PR
Total Statements Coverage  70.02%  70.56%  (+0.54%)
Total Branches Coverage  69.14%  69.4%  (+0.26%)
Total Functions Coverage  82.18%  82.34%  (+0.16%)
Total Lines Coverage  70.02%  70.56%  (+0.54%)
Details (changed files):
File Statements Branches Functions Lines

JoernBerkefeld
JoernBerkefeld commented Jul 21, 2024
View reviewed changes
test/type.automation.test.js Show resolved Hide resolved
test/general.test.js Show resolved Hide resolved
test/general.test.js Show resolved Hide resolved
test/general.test.js Show resolved Hide resolved
test/general.test.js Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
lib/metadataTypes/Asset.js Show resolved Hide resolved
lib/util/replaceContentBlockReference.js Show resolved Hide resolved
lib/util/replaceContentBlockReference.js Show resolved Hide resolved
lib/util/replaceContentBlockReference.js Show resolved Hide resolved
JoernBerkefeld and others added 11 commits July 22, 2024 17:09
@JoernBerkefeld
#1475: list folder type "asset" as potentially shared folder type
d772886
@JoernBerkefeld
#1443: include asset field objectID in caching request
aac3ec2
@JoernBerkefeld
#1475: sorted subtype list
cffe7d7
@JoernBerkefeld
#1475: ensure we only load folders that are actually shareable
90220e3
@JoernBerkefeld
Merge pull request #1476 from Accenture/bug/1475-get-folder-type-asse…
9210d1f 
…t-from-parent-via-queryallaccounts

Bug/1475 get folder type asset from parent via queryallaccounts
@JoernBerkefeld
#1471: replace --noMidSuffix with --autoMidSuffix
26d9808
@JoernBerkefeld
#1471: adapt tests to --noMidSuffix getting replaced by --autoMidSuffix
e808657
@JoernBerkefeld
Merge pull request #1477 from Accenture/feature/1471-make-nomidsuffix…
1ce2a39 
…-the-default-and-add-automidsuffix-instead

Feature/1471 make nomidsuffix the default and add automidsuffix instead
@JoernBerkefeld
#1443: improve log output
4f463a2
@JoernBerkefeld
#1443: no longer include sharing info for assets in templates created…
d385abf 
… by buildTemplate to avoid deployment errors
@JoernBerkefeld
#0: improve logs
7c81c67
@JoernBerkefeld JoernBerkefeld merged commit 5bb9ecf into develop Jul 22, 2024
12 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/1443-enhance-bt-dependencies-with-ampscriptssjs-parsing branch July 22, 2024 17:24
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
Closed
@JoernBerkefeld JoernBerkefeld restored the feature/1443-enhance-bt-dependencies-with-ampscriptssjs-parsing branch July 22, 2024 17:24
@JoernBerkefeld JoernBerkefeld deleted the feature/1443-enhance-bt-dependencies-with-ampscriptssjs-parsing branch July 22, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
e/DevOps EPIC e/IDE EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] enhance bt --dependencies with ampscript/ssjs parsing
1 participant
@JoernBerkefeld