Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/1472 adapt order in which assets are deployed for inter-type dependencies #1502

Merged
merged 13 commits into from
Aug 31, 2024
Merged

BUG/1472 adapt order in which assets are deployed for inter-type dependencies #1502

merged 13 commits into from
Aug 31, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jul 25, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/asset COMPONENT label Jul 25, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.1.1 milestone Jul 25, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 25, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Jul 25, 2024 that may be closed by this pull request
[BUG] adapt order in which assets are deployed for inter-type dependencies #1472
Closed
@github-actions github-actions bot added the bug Something isn't working label Jul 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Coverage Report

Commit:ed61d71
Base: develop@f6d69db

Type Base This PR
Total Statements Coverage  70.09%  69.99%  (-0.1%)
Total Branches Coverage  68.83%  68.86%  (+0.03%)
Total Functions Coverage  82.11%  81.89%  (-0.22%)
Total Lines Coverage  70.09%  69.99%  (-0.1%)
Details (changed files):
File Statements Branches Functions Lines
lib/index.js  71.38%  65.05%  72.09%  71.38%
lib/metadataTypes/Asset.js  76.91%  67.41%  87.75%  76.91%
lib/metadataTypes/MetadataType.js  82.54%  80.04%  76.25%  82.54%
lib/util/replaceContentBlockReference.js  96.38%  91.3%  100%  96.38%
lib/util/util.js  85.98%  75%  92.68%  85.98%

@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.1, 7.1.2 Jul 25, 2024
@JoernBerkefeld JoernBerkefeld marked this pull request as draft July 25, 2024 12:14
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.2, 7.1.3, 7.1.4 Jul 30, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.4, 7.1.5 Aug 8, 2024
@JoernBerkefeld
Merge branch 'develop' into bug/1472-adapt-order-in-which-assets-are-…
9d221cf 
…deployed-for-inter-type-dependencies

# Conflicts:
#	@types/lib/index.d.ts.map
#	@types/lib/metadataTypes/Asset.d.ts.map
#	@types/lib/metadataTypes/MetadataType.d.ts.map
#	@types/lib/util/util.d.ts.map
@JoernBerkefeld
#0: update copyright note
8147ad5
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.5, 7.1.6 Aug 13, 2024
@JoernBerkefeld JoernBerkefeld removed this from the 7.1.5 milestone Aug 22, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.6, 7.2.1, 7.2.2 Aug 22, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.3.1, 7.3.2 Aug 30, 2024
@JoernBerkefeld
Merge branch 'develop' into bug/1472-adapt-order-in-which-assets-are-…
4e9884b 
…deployed-for-inter-type-dependencies

# Conflicts:
#	lib/index.js
@JoernBerkefeld JoernBerkefeld marked this pull request as ready for review August 30, 2024 22:30
@JoernBerkefeld
Copy link
Contributor Author

JoernBerkefeld commented Aug 30, 2024 •
edited
Loading

needs a rewrite of the upsert method to process things sequentially like for folders

@JoernBerkefeld JoernBerkefeld merged commit 105c5d2 into develop Aug 31, 2024
8 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1472-adapt-order-in-which-assets-are-deployed-for-inter-type-dependencies branch August 31, 2024 21:02
@github-actions github-actions bot mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

[BUG] adapt order in which assets are deployed for inter-type dependencies
1 participant
@JoernBerkefeld