Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/1631 improve configurationArgument checks incl common vs contact logic for salesforce data entry events #1632

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Task/1631 improve configurationArgument checks incl common vs contact logic for salesforce data entry events #1632

merged 5 commits into from
Aug 30, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Aug 29, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added c/event COMPONENT c/journey COMPONENT labels Aug 29, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.3.1 milestone Aug 29, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Aug 29, 2024 that may be closed by this pull request
[TASK] improve common-vs-contact checks for Salesforce data entry events #1631
Closed
@github-actions github-actions bot added the chore Jira issue-type "Task" label Aug 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Coverage Report

Commit:fef681d
Base: develop@5da1153

Type Base This PR
Total Statements Coverage  70.1%  70.08%  (-0.02%)
Total Branches Coverage  68.84%  68.84%  (+0%)
Total Functions Coverage  82.21%  82.08%  (-0.13%)
Total Lines Coverage  70.1%  70.08%  (-0.02%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld self-assigned this Aug 29, 2024
@JoernBerkefeld JoernBerkefeld mentioned this pull request Aug 30, 2024
Closed
@JoernBerkefeld JoernBerkefeld linked an issue Aug 30, 2024 that may be closed by this pull request
[TASK] error check configurationArguments.contactKey in eventDefinitions #1603
Closed
@JoernBerkefeld JoernBerkefeld merged commit 0fc5335 into develop Aug 30, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1631-improve-common-vs-contact-checks-for-salesforce-data-entry-events branch August 30, 2024 09:31
@github-actions github-actions bot mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/event COMPONENT c/journey COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.3.1
1 participant
@JoernBerkefeld