Feature/9 add filterDefinition & resolve filter details #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-&-resolve-filter-details-CSCLSROZ-410-+-CSCLSROZ-411
JoernBerkefeld
added
enhancement
JoernBerkefeld
changed the title
3 tasks
DougMidgley
requested changes
Jan 16, 2022
|
|
||
| // source | ||
| if (metadata.sourceTypeId === 1) { | ||
| // list |
lib/metadataTypes/Filter.js
Outdated
| * @returns {FilterItem} parsed metadata definition | ||
| */ | ||
| static parseMetadata(metadata) { | ||
| try { |
There was a problem hiding this comment.
this error is already handled in the saveResults method (only failing the individual record) so should be avoided here as will likely hide other errors/require additional checks in saveResults method
|
|
||
| // target | ||
| if (metadata.destinationTypeId === 1) { | ||
| // list |
| static async retrieve(retrieveDir) { | ||
| // #1 get the list via SOAP cause the corresponding REST call has no BU filter apparently | ||
| // for reference the rest path: '/automation/v1/filterdefinitions?view=categoryinfo' | ||
| const keyFieldBak = this.definition.keyField; |
| * @returns {Promise<FilterDefinitionItem>} Promise | ||
| */ | ||
| static update(metadata) { | ||
| // TODO test the update |
There was a problem hiding this comment.
if its not tested, then wouldnt it be better to not have this in the PR?
There was a problem hiding this comment.
in my defense - the PR is still in draft mode.
…filter-details # Conflicts: # docs/dist/documentation.md # lib/metadataTypes/Filter.js
…filter-details # Conflicts: # docs/dist/documentation.md # lib/metadataTypes/Filter.js
…feature/9-Add-filterDefinition-&-resolve-filter-details # Conflicts: # docs/dist/documentation.md # types/mcdev.d.js
…filter-details # Conflicts: # docs/dist/documentation.md # lib/metadataTypes/Filter.js # package-lock.json # package.json
JoernBerkefeld
changed the title
…filter-details # Conflicts: # package-lock.json # package.json
…filter-details # Conflicts: # docs/dist/documentation.md # package-lock.json # package.json
Coverage ReportCommit:15548a6Base: develop@5ac58b3
Details (changed files):
|
…inition details; split off hidden ones, resolve filterDefinition in filter
JoernBerkefeld
changed the title
JoernBerkefeld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR details
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
To-Do
Checklist