-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/294 task run checkproperties on config load #324
Draft
DougMidgley
wants to merge
19
commits into
develop
Choose a base branch
from
task/294-task-run-checkproperties-on-config-load
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6522f65
#294: Initial Carve out
3a39960
Merge branch 'develop' of https://github.com/Accenture/sfmc-devtools …
3e555d7
#294: capitalization change
e92652b
#294: moved to error-based handling
e4c5377
Merge branch 'develop' of https://github.com/Accenture/sfmc-devtools …
e669631
#294: top level error handling on CLI
c71eb3f
#294: review feedback
350aecd
Merge branch 'develop' of https://github.com/Accenture/sfmc-devtools …
1e93419
Merge branch 'develop' of https://github.com/Accenture/sfmc-devtools …
bc01163
Merge branch 'develop' of https://github.com/Accenture/sfmc-devtools …
bb47453
#346: turn auth class into properly named (and resolved) object
JoernBerkefeld 45e2cf1
#294: jsdoc and function expression changed to function declaration
JoernBerkefeld 7ffd72e
#294: fix bad reference
JoernBerkefeld 4157213
#294: extracted getProblems()
JoernBerkefeld 0ba3e76
#294: skipChecks param in getProperties()
JoernBerkefeld 169650e
#294: missing Util ref
cf78dcc
#294: bad class reference fixed
JoernBerkefeld 2c0f27f
#294: fix error handler to no longer fail on "mcdev" without params
JoernBerkefeld 2015df4
#294: otherwise causing loop
JoernBerkefeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our adaption of Util.logger.error already sets the exit code to 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sfmc-devtools/lib/util/util.js
Line 499 in bc01163
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also there is a method to wrap around exit code 1:
sfmc-devtools/lib/util/util.js
Line 131 in bc01163
apparently the right way to do it for async-functions was
process.exitCode = 1;
here more on the why: https://nodejs.dev/learn/how-to-exit-from-a-nodejs-program