Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/#198 import file activity missing #891

Merged
merged 2 commits into from
May 4, 2023
Merged

Bugfix/#198 import file activity missing #891

merged 2 commits into from
May 4, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

PR details

What changes did you make? (Give an overview)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • n/a test scripts updated
  • n/a Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 5.0.0 milestone May 4, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this May 4, 2023
@JoernBerkefeld JoernBerkefeld added the c/importFile COMPONENT label May 4, 2023
@github-actions github-actions bot added the bug Something isn't working label May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

Coverage Report

Commit: 9821578
Base: develop@e3e237e

Type Base This PR
Total Statements Coverage  40.9%  40.87%  (-0.03%)
Total Branches Coverage  32.43%  32.43%  (+0%)
Total Functions Coverage  47.17%  47.17%  (+0%)
Total Lines Coverage  40.84%  40.82%  (-0.02%)
Details (changed testable files):
File Statements Branches Functions Lines
lib/Builder.js  59.4%  33.33%  81.81%  59%
lib/util/util.js  58.14%  44.53%  77.77%  57.46%

github-advanced-security[bot]
github-advanced-security bot found potential problems May 4, 2023
View reviewed changes
lib/util/util.js
if (hideOutput) {
// no output displayed to user but instead returned to parsed elsewhere
return child_process
.execSync(cmd + ' ' + args.join(' '))

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

This string concatenation which depends on [library input](1) is later used in a [shell command](2). This string concatenation which depends on [library input](3) is later used in a [shell command](2).
lib/util/util.js
} else {
// the following options ensure the user sees the same output and
// interaction options as if the command was manually run
child_process.execSync(cmd + ' ' + args.join(' '), { stdio: [0, 1, 2] });

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

This string concatenation which depends on [library input](1) is later used in a [shell command](2). This string concatenation which depends on [library input](3) is later used in a [shell command](2).
@JoernBerkefeld JoernBerkefeld merged commit 52e1883 into develop May 4, 2023
@JoernBerkefeld JoernBerkefeld deleted the bugfix/198--import-file-activity-missing branch May 4, 2023 21:08
@github-actions github-actions bot mentioned this pull request May 4, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/importFile COMPONENT
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JoernBerkefeld