Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/896 federation ids are not getting updated while trying to update users for sso #902

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented May 9, 2023

PR details

What changes did you make? (Give an overview)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • n/a test scripts updated
  • Wiki updated

Wiki

https://github.com/Accenture/sfmc-devtools/wiki/08.-Metadata-specific-settings-%26-options/_edit

    "SsoIdentity": {
        "IsActive": true, // true enables SSO, false disables SSO
        "FederatedID": "test-mcdev" // make sure to replace test-mcdev with the actual value from your SSO provider for this user
    }

Full example:

{
    "CreatedDate": "2021-06-22T14:49:02.99",
    "ModifiedDate": "2021-06-22T14:54:07.45",
    "CustomerKey": "0cea7619-8ea9-41e2-97a3-d9a33dc0847a",
    "UserID": "test-mcdev@accenture.com",
    "Name": "NameOfTheUser",
    "Email": "test-mcdev@accenture.com",
    "MustChangePassword": true,
    "ActiveFlag": true,
    "UserPermissions": [],
    "LastSuccessfulLogin": "2021-06-22T14:49:02.99",
    "IsAPIUser": true,
    "NotificationEmailAddress": "test-mcdev@accenture.com",
    "DefaultBusinessUnit": 7281698,
    "c__type": "User",
    "c__AccountUserID": 717142520,
    "c__IsLocked_readOnly": false,
    "c__AssociatedBusinessUnits": [
        7281698
    ],
    "c__RoleNamesGlobal": [
        "My super role",
    ],
    "c__TimeZoneName": "(GMT+01:00) Amsterdam, Berlin, Bern, Rome, Stockholm, Vienna *",
    "c__LocaleCode": "en-GB",
    "SsoIdentity": {
        "IsActive": true,
        "FederatedID": "test-mcdev"
    }
}

@JoernBerkefeld JoernBerkefeld added the c/user COMPONENT label May 9, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.0.1 milestone May 9, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this May 9, 2023
@github-actions github-actions bot added the bug Something isn't working label May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Coverage Report

Commit: 42ad719
Base: develop@7563fa6

Type Base This PR
Total Statements Coverage  40.87%  40.82%  (-0.05%)
Total Branches Coverage  32.43%  32.33%  (-0.1%)
Total Functions Coverage  47.17%  47.17%  (+0%)
Total Lines Coverage  40.82%  40.76%  (-0.06%)
Details (changed testable files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit 32bbf59 into develop May 9, 2023
@JoernBerkefeld JoernBerkefeld deleted the bugfix/896-federation-ids-are-not-getting-updated-while-trying-to-update-users-for-sso branch May 9, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/user COMPONENT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant