Added server settings configuration using environment variables. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a typo
Trying to make the instruction more clear
Fix the docker-compose.yaml typo
I've goten some issues when trying to run the server, it just crashed and wasn't working until I changed the CPU type of my hypervisor. I thought that this might be some information worth sharing.
|
Environment variables can be set as follows: - ASAINI_GameUserSettings__ServerSettings__ShowFloatingDamageText=True |
|
This is a very important PR for the flexibility of that ASA container. I want to get rid of manually editing INI files. Please proceed asap! |
|
@Acekorneya shall I resolve the outstanding conflicts? Or is this not the way that is desired we could also go with a small file and add dotnet to the dependencies of the docker image if that'd be better? |
|
Do you know how to resolve the current problem of some user having permission issues when they run this docker image under a root user |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to generate their ini files using environment variables.
A small C# tool was added to parse ini files and and set the values inside of them to the set environment variables.
I also added a gitignore file to prevent uploading build files and the default volumes.
The readme was changed to help users use the new system.
Dockerfile was updated to build the IniGenerator tool and add it to the main container.
I hope that this is something you are also appreciating and is not going into the wrong direction with the project.
If there are any questions drop a quick comment and I'll try to answer as quick as possible.