build: add vite support #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjare
force-pushed
the
dev/migrate-to-vite
branch
from
7109abc to
36855f0
Compare
ErikBjare
commented
May 1, 2024
| @@ -13,6 +13,6 @@ | |||
| <strong>We're sorry but the ActivityWatch Web UI doesn't work properly without JavaScript enabled. Please enable it to continue.</strong> | |||
| </noscript> | |||
| <div id="app"></div> | |||
| <!-- built files will be auto injected --> | |||
| <script type="module" src="/src/main.js"></script> | |||
There was a problem hiding this comment.
Thought this would mess up the webpack build... But seems to work.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 25.55% 25.60% +0.04%
==========================================
Files 27 27
Lines 1616 1613 -3
Branches 273 273
==========================================
Hits 413 413
+ Misses 1177 1174 -3
Partials 26 26 ☔ View full report in Codecov by Sentry. |
styles fixed by disabling vite server CSP
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| themeLink.href = '/dark.css'; // darkCssUrl | ||
| themeLink.rel = 'stylesheet'; | ||
| // Append Dark Theme Element If Selected Mode Is Dark | ||
| theme === 'dark' ? document.querySelector('head').appendChild(themeLink) : ''; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
ErikBjare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to keep the webpack build intact for now, while trying to get a working build with vite.
TODO
If we are done with the above, we can merge and continue the following in a new PR:
Failed to resolve entry for package "vue-d3-sunburst". The package may have incorrect main/module/exports specified in its package.json