fix: Correct encoding in category filter links on summary view #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 91e418f in 19 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. /src/components/SelectableVisualization.vue:67:
- Assessed confidence :
0% - Comment:
The use ofencodeURIComponentfor encoding URL parameters is appropriate and correctly implemented here. This ensures that special characters in category names do not break the URL structure. - Reasoning:
The PR aims to fix an issue with encoding category names in URLs. The change usesencodeURIComponentto encode the category names, which is a standard method for encoding URI components to ensure special characters are correctly represented in URLs. This is a common practice to prevent issues such as spaces and other special characters breaking the URL format. The change is made in thelinkfuncwhich constructs the URL for category filter links. This seems appropriate and correctly implemented based on the PR description and the issue it addresses.
Workflow ID: wflow_Ca9BbnHR95t4i0tO
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 12 days left in your free trial, upgrade for $20/seat/month or contact us.
|
Very good! Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ActivityWatch/activitywatch#1051
This change ensures category names in the summary view URLs are web-compatible by encoding them with
encodeURIComponent.Summary:
Updated the
linkfuncinaw-summaryfor 'top_categories' to encode category names usingencodeURIComponentfor URL compatibility in/src/components/SelectableVisualization.vue.Key points:
linkfuncinaw-summaryfor 'top_categories' in/src/components/SelectableVisualization.vue.encodeURIComponentfor URL compatibility.Generated with ❤️ by ellipsis.dev