add a default color for Media category #593
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 9fd6513 in 58 seconds
More details
- Looked at
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_RrGqEVDCnMyEXEa3
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
src/util/classes.ts
Outdated
| @@ -49,6 +49,11 @@ export const defaultCategories: Category[] = [ | |||
| { name: ['Work', 'Video'], rule: { type: 'regex', regex: 'Kdenlive' } }, | |||
| { name: ['Work', 'Audio'], rule: { type: 'regex', regex: 'Audacity' } }, | |||
| { name: ['Work', '3D'], rule: { type: 'regex', regex: 'Blender' } }, | |||
| { | |||
| name: ['Media'], | |||
| rule: { type: null }, | |||
There was a problem hiding this comment.
The rule type is set to null which is not a valid value according to the Rule interface definition. It should be either 'regex' or 'none'.
| rule: { type: null }, | |
| rule: { type: 'none' }, |
There was a problem hiding this comment.
Apparently there are several instances of null instead of 'none', not sure why these aren't caught in CI.
There was a problem hiding this comment.
I'll try to chase them down and replace with 'none'
There was a problem hiding this comment.
I can't find any other instance of null used in the rules
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #593 +/- ##
=======================================
Coverage 26.13% 26.13%
=======================================
Files 27 27
Lines 1630 1630
Branches 281 286 +5
=======================================
Hits 426 426
Misses 1145 1145
Partials 59 59 ☔ View full report in Codecov by Sentry. |
The color value is a placeholder, should you choose to change it 😄
Summary:
Added default color
#F33for 'Media' category indefaultCategoriesarray insrc/util/classes.ts.Key points:
#F33for 'Media' category indefaultCategoriesarray.src/util/classes.tsto include the color in thedatafield of the 'Media' category object.Generated with ❤️ by ellipsis.dev