-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove broken api browser link #614
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 89909b2 in 7 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. src/views/Home.vue:55
- Draft comment:
Ensure that the API Browser link is indeed broken and not just temporarily down. If there are other references to the API Browser elsewhere in the codebase, consider removing or updating them as well. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes a broken link to the API Browser. This is a straightforward change, but it's important to ensure that the link is indeed broken and not just temporarily down. Additionally, it's good to check if there are any other references to the API Browser elsewhere in the codebase that might also need removal or updating.
Workflow ID: wflow_WhC3Il8RHx8KPkom
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #614 +/- ##
=======================================
Coverage 25.98% 25.98%
=======================================
Files 27 27
Lines 1643 1643
Branches 279 287 +8
=======================================
Hits 427 427
+ Misses 1190 1157 -33
- Partials 26 59 +33 ☔ View full report in Codecov by Sentry. |
Only broken in aw-server-rust, works fine for aw-server-python. |
I figured most people are running the rust server. I can just wrap in it in a |
Sounds good! |
9ea531a
to
8027166
Compare
Important
Remove broken "API Browser" link from
Home.vue
.Home.vue
under the Resources section.This description was created by for 89909b2. It will automatically update as commits are pushed.