Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove broken api browser link #614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Oct 21, 2024

Important

Remove broken "API Browser" link from Home.vue.

  • Behavior:
    • Removed broken "API Browser" link from Home.vue under the Resources section.

This description was created by Ellipsis for 89909b2. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 89909b2 in 7 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/views/Home.vue:55
  • Draft comment:
    Ensure that the API Browser link is indeed broken and not just temporarily down. If there are other references to the API Browser elsewhere in the codebase, consider removing or updating them as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes a broken link to the API Browser. This is a straightforward change, but it's important to ensure that the link is indeed broken and not just temporarily down. Additionally, it's good to check if there are any other references to the API Browser elsewhere in the codebase that might also need removal or updating.

Workflow ID: wflow_WhC3Il8RHx8KPkom


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@0xbrayo 0xbrayo changed the title chore: remove broke api browser link chore: remove broken api browser link Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.98%. Comparing base (291da6f) to head (848aeaf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   25.98%   25.98%           
=======================================
  Files          27       27           
  Lines        1643     1643           
  Branches      279      287    +8     
=======================================
  Hits          427      427           
+ Misses       1190     1157   -33     
- Partials       26       59   +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare
Copy link
Member

Only broken in aw-server-rust, works fine for aw-server-python.

@0xbrayo
Copy link
Member Author

0xbrayo commented Oct 22, 2024

I figured most people are running the rust server. I can just wrap in it in a v-if block to display only on python server.

@ErikBjare
Copy link
Member

Sounds good!

@0xbrayo 0xbrayo force-pushed the master branch 2 times, most recently from 9ea531a to 8027166 Compare October 24, 2024 19:02
@0xbrayo 0xbrayo closed this Oct 25, 2024
@0xbrayo 0xbrayo reopened this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants