Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Michelle - Edges - MediaRanker-Revisited #25

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

kangazoom
Copy link

are there no questions to answer?

@droberts-sea
Copy link

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Appropriate Tests on WorksController yes
Appropriate Tests on SessionsController yes
Appropriate Tests on UsersController yes
Completed OAuth yes
Basic Authorization (who can see what) some
Overall Good work overall. Make sure you review testing around authentication and authorization - this isn't something we'll cover further in class, but the concepts (especially mocking) are very useful in the real world.

@@ -1,7 +1,7 @@
class ApplicationController < ActionController::Base
protect_from_forgery with: :exception

before_action :find_user
before_action :find_user, except: [:root]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably add a before_action here for must_login. That will make any new actions you add require login by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants