Michelle and Katrina - Edges - OO-Ride-Share #23

kangazoom · 2018-09-01T01:26:58Z

OO Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer	Instructor Feedback
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	In TripDispatcher#request_trip, we decided to find the maximum trip ID and add to it instead of merely finding the length so that if the IDs are not in sequential order, then the code will still run correctly. We also refactored our code to use enumerables to enhance readability in case we needed to edit it in the future.
Describe any examples of composition that you encountered in this project, if any	In TripDispatcher, we created a method called request_trip and inside that method, we called methods in other classes. For example, we created a new instance of Driver and called new_driver.status as well as added the new trip to the Driver like new_driver.add_diven_trip(trip). We also did the same by creating a new passenger and calling a method from the passenger/user class like new_passenger.add_trip(trip).	Your answer gets at this, but I want to call out this vocab explicitly. By composition we mean a has-a or has-many relationship. Examples in this project include "a TripDispatcher has-many Drivers, Passengers and Trips", "a Driver has-many Trips", "a Trip has-a Driver".
Describe the relationship between `User` and `Driver`	Driver inherits from User, meaning that all of User's methods are available to the Driver without needing to create them. Further, the Driver is a type of User.
Describe a nominal test that you wrote for this assignment.	For request_status in TripDispatch_spec, we wrote a test called "Connects passenger with trip in progress" in which we checked to make sure the Passenger instance stored in the in-progress Trip instance matched the Passenger instance that was added to the Trip.
Describe an edge case test that you wrote for this assignment	For net_expenditures in Driver_spec, we created a test called "returns a float with correct money format" in which we checked what would happen if we got a money value return that went beyond two decimal places in order to ensure it only returned those two decimal places.
Describe a concept that you/your pair gained more clarity on as you worked on this assignment	We learned a lot about taking input as a parameter and what is actually necessary to instantiate a new class instance. We also learned more about debugging errors in the code we wrote versus the tests we wrote.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	(1) We discussed telling each other right away before we went down a long path of code whether or not we thought it would work and why. (2) We discussed giving each other space to think through and figure out code/issues before diving in.

…ion plus tests

…nue for driver)

kangazoom · 2018-09-01T01:38:03Z

should we resolve conflicts??

specs/driver_spec.rb
specs/test_data/trips_test.csv

droberts-sea · 2018-09-08T02:06:51Z

Ride Share

What We're Looking For

Feature	Feedback
Baseline
Used Git Regularly	yes
Answer comprehension questions	yes - see feedback above
Wave 1
Appropriate use of Ruby's `Date`	yes
`Trip` has a helper method to calculate duration	yes
`User` (passenger) has a method to calculate total cost of all trips	yes
Tests for wave 1	missing some edge cases - see inline
Wave 2
`Driver` inherits from `User`	yes
`Driver` has `add_driven_trip` method	yes
`Driver` has method to calculate average rating	yes
`Driver` has method to calculate net expenditures and it uses `super`	yes
`Driver` has a method to calculate total revenue	yes
Tests for wave 2	mostly
Wave 3
`TripDispatcher` has a new method to create trips	yes
creating a trip in `TripDispatcher` relies on methods in `Driver` and `User` (passenger) to modify their own attributes	no (sets driver status directly)
Complex logic was correctly implemented	yes
Tests for `request_trip`	mostly
Methods from wave 1 and 2 handle incomplete trips	yes
Tests for wave 1 and 2 methods with incomplete trips	no
Overall	Great job overall! This is a strong submission. There are a few places where things could be cleaned up or test coverage expanded, but in general I'm pretty happy with what I see. Keep up the hard work!

droberts-sea · 2018-09-08T02:00:06Z

lib/user.rb

+    def net_expenditures()
+      valid_trips = @trips.reject { |trip| trip.cost.nil? }
+      return valid_trips.sum { |trip| trip.cost} if valid_trips.length > 0
+    end


Great use of enumerables through here!

droberts-sea · 2018-09-08T02:01:04Z

specs/user_spec.rb

+  describe "user#net_expenditures" do
+    before do
+      @user = RideShare::User.new(id: 9, name: "Merl Glover III",
+                                  phone: "1-602-620-2330 x3723", trips: [])


I think you're missing some edge cases that are common to both these User methods:

What happens if the user has no trips?

What happens if the user has an incomplete trip?

droberts-sea · 2018-09-08T02:01:55Z

lib/driver.rb

+
+      if !(super.nil? && total_driver_revenue.nil?)
+	       return ("%.2f" % (super - total_driver_revenue)).to_f
+      end


Good use of super here

droberts-sea · 2018-09-08T02:04:05Z

specs/driver_spec.rb

    end
  end

-  describe "average_rating method" do
+  describe "net_expenditures" do
    before do
      @driver = RideShare::Driver.new(id: 54, name: "Rogers Bartell IV",


You're missing some interesting cases here. What if a driver has

No driven trips

No trips as a passenger

An incomplete trip as either a driver or passenger

Made more money than they've spent

droberts-sea · 2018-09-08T02:05:12Z

lib/trip_dispatcher.rb

+    def request_trip(user_id)
+      current_passenger = find_passenger(user_id)
+      available_driver = @drivers.find { |driver| driver.status == :AVAILABLE }
+


You're not screening for getting the same person who requested this trip

droberts-sea · 2018-09-08T02:06:13Z

specs/trip_dispatch_spec.rb

+
+  describe 'Request Trip Method ' do
+    before do
+    @dispatcher = RideShare::TripDispatcher.new(USER_TEST_FILE, TRIP_TEST_FILE, DRIVER_TEST_FILE)


What happens if there are no drivers available?

kangazoom and others added 30 commits August 27, 2018 15:25

Wave 1: modified TripDispatcher#load_trips and Trip#initialize except…

d99ed0f

…ion plus tests

Added calculate_trip_duration method and its corresponding test

b8d529b

Oops did not save the changes

4fc706e

Wave 1.2: implemented user#net_expenditures

5228ce3

Rewrote code for user#net_expenditures and created user#total_time_spent

deabd99

added driver.rb

262d3c8

Wave 2: added to driver.rb

a4eacf8

not sure what we did here

19cc122

Created a driver. Great.

dc8b338

we finally added a driver instance

05e228b

passed tests

9983780

updated trip and specs

a546107

Wave 2: started loading driver; ~more to come~

6779b38

fixed some of load_drivers in trip_dispatcher.rb

eb8017e

loading drivers

c7933ea

updated load driver

d17b561

WE DID IT WE LOADED A DRIVER WOOHOO

b3dff1b

worked out time conflict

056c70f

added average and driven_trips functions to driver

9013f41

added a note to driver about status

5ae2c3b

added average rating method

16a9aea

added tests for total revenue, but need more

8b8e456

designated default status to available if nil

360058d

added net expenditures method

28f8ed4

finished wave 2 methods and tests (in driver.rb)

16c5dc2

Added change driver status and request trip

4bb4d1e

added notes for our to do list

e642d10

started wave 3, added notes on what to do next

17542c2

trying to get trip_dispatcher tests to pass

ec3885a

commented code in trip_dispatcher

22853d7

kaganon and others added 12 commits August 31, 2018 13:16

passed test to initialize trip dispatcher

e17a090

fixed test for initializing trip dispatcher

c842deb

changed 'connects drivers with trips' test in trip_dispatcher

ffab027

ignored nil values in end_time, cost, rating

cd3a815

added some more nil calculation checks (average rating and total reve…

3495784

…nue for driver)

fixed errors in average rating for driver for nil

fc2a6ab

Added tests for wave 3

a8ad4f9

Merge branch 'master' of https://github.com/kangazoom/oo-ride-share

3c3d5e0

finished final test for trip_dispatch (request status)

9dd73e2

cleaned up lib files and refactored nil tests

cc9b5f0

cleaned up all tests

4a4dad1

fixed whitespace in trip_dispatch_spec

1ec5242

droberts-sea reviewed Sep 8, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Michelle and Katrina - Edges - OO-Ride-Share #23

Michelle and Katrina - Edges - OO-Ride-Share #23

kangazoom commented Sep 1, 2018 •

edited by droberts-sea

Loading

kangazoom commented Sep 1, 2018

droberts-sea commented Sep 8, 2018

droberts-sea Sep 8, 2018

droberts-sea Sep 8, 2018

droberts-sea Sep 8, 2018

droberts-sea Sep 8, 2018

droberts-sea Sep 8, 2018

droberts-sea Sep 8, 2018

Michelle and Katrina - Edges - OO-Ride-Share #23

Are you sure you want to change the base?

Michelle and Katrina - Edges - OO-Ride-Share #23

Conversation

kangazoom commented Sep 1, 2018 • edited by droberts-sea Loading

OO Ride Share

Comprehension Questions

kangazoom commented Sep 1, 2018

droberts-sea commented Sep 8, 2018

Ride Share

What We're Looking For

droberts-sea Sep 8, 2018

Choose a reason for hiding this comment

droberts-sea Sep 8, 2018

Choose a reason for hiding this comment

droberts-sea Sep 8, 2018

Choose a reason for hiding this comment

droberts-sea Sep 8, 2018

Choose a reason for hiding this comment

droberts-sea Sep 8, 2018

Choose a reason for hiding this comment

droberts-sea Sep 8, 2018

Choose a reason for hiding this comment

kangazoom commented Sep 1, 2018 •

edited by droberts-sea

Loading