forked from AdaGold/palindrome-check
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lj palindrome #37
Open
elle-johnnie
wants to merge
3
commits into
Ada-C10:master
Choose a base branch
from
elle-johnnie:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
lj palindrome #37
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,41 @@ | ||
# A method to check if the input string is a palindrome. | ||
# Return true if the string is a palindrome. Return false otherwise. | ||
def palindrome_check(my_phrase) | ||
raise NotImplementedError | ||
# check for nil | ||
unless my_phrase.nil? | ||
i = 0 | ||
last = my_phrase.length - 1 | ||
while i < last # O(n/2) | ||
# iterate from head of string until non whitespace char | ||
until my_phrase[i] != ' ' # O(n/2) | ||
i += 1 | ||
end | ||
|
||
# iterate from tail of string until non whitespace char | ||
until my_phrase[last] != ' ' # O(n/2) | ||
last -= 1 | ||
end | ||
|
||
|
||
# once two non-whitespace characters are found compare them | ||
if my_phrase[i] != my_phrase[last] | ||
return false | ||
else | ||
i += 1 | ||
last -= 1 | ||
end | ||
end | ||
|
||
return true | ||
end | ||
|
||
return false | ||
end | ||
|
||
# For time complexity I think the overall number of operations is dependent on the | ||
# length of the string/phrase (n) At most 1/2 of the length of the string | ||
# operations will be necessary to iterate over (the head and tail | ||
# increment/decrement in unison) O(n) | ||
# Using this method no additional space is required beyond the | ||
# head and tail incrementors as all non-whitespace characters are checked in | ||
# place and only a boolean is returned O(n) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nicely done! The time complexity is correct. The space complexity of your algorithm is O(1). See my implementation of the same algorithm on https://github.com/Ada-C10/palindrome_check/blob/solution/lib/palindrome_check.rb |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any comments on the time and space complexity. Can you think through the time and space complexity of your algorithm?
Gentle reminder: Always explain what n stands for while explaining your time and space complexity. That along with your explanation for reasoning behind your answer, is the complete answer for the time and space complexity. In this case, n is the number of characters in the input string parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback Shruti this is very helpful -I pushed up a refactor on this and included my thoughts on T and S complexity following your feedback above. I'm not confident in in my answer on T complexity when while loops are nested within each other so if you have clarification on calculating those I appreciate it!