Shelan's portfolio #21

sheland · 2018-09-17T11:26:37Z

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	I had errors stating "element li not allowed as child of element in this context." I resolved them but not all of them because it didn't negatively impact the layout of my portfolio.
Why is it important to consider and use semantic HTML?	It lets users know the contexts of your file by simply looking at the tags. It aids communication by being clear of the meaning of the page.
How did you decide to structure your CSS?	I used css grid and flex-box. I probably heavily relied more on flex-box because I found myself playing with the margins/padding longer than expected.
What was the most challenging piece of this assignment?	Adding links and images, I had a hard time establishing the proper pathway. Adding spacing between flex items and adding animation.
Describe one area that you gained more clarity on when completing this assignment	I believe I have a greater understanding of the funflex-box, I really enjoyed manipulating the spacing of items even though at times it got a bit tricky.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

CheezItMan · 2018-09-21T16:43:15Z

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	Very few commits and not very descriptive commit messages.
Answered comprehension questions	Check
Page fully loads	Check, with error
No broken links (regular or images)	Check
Includes at least 4 pages and styling	Check
HTML
Uses the high-level tags for organization: `header, footer, main`	Yes
Appropriately using semantic tags: `section, article`, etc.	Check, although I would use `header` instead of having a `section` with a class set to `header`
All images include alternate text	Check
CSS
Using class and ID names in style declarations	Check
Style declarations are DRY	Could be DRYer
Overall	The pages work, but you have some invalid HTML and CSS. You also could make the CSS more DRY. Overall not bad and you hit the majority of the learning goals for the project.

CheezItMan · 2018-09-21T16:23:22Z

index(port).html

@@ -0,0 +1,33 @@
+<!DOCTYPE html>


Did you export this file from a 3rd party program? Why is (port) in the filename.

CheezItMan · 2018-09-21T16:26:51Z

blog_posts.html

@@ -0,0 +1,21 @@
+<section class="blogs">


Note: This file isn't valid HTML.

CheezItMan · 2018-09-21T16:29:31Z

about.html

+    <body>
+
+      <section class="header">
+        <li><a href="portfolio.html">portfolio.</a></li>


li elements must be children of ul or ol elements.

CheezItMan · 2018-09-21T16:30:19Z

contact.html

+        <footer>
+          <ul class="footer">
+            <li>© 2018-</li>
+            <li>contact information: shelandebesai@gmail.com <a href="shelandebesai@gmail.com">


This li element isn't closed.

Also the a element isn't closed

CheezItMan · 2018-09-21T16:32:19Z

index(port).html

+  <body class="container">
+
+    <section class="header">
+      <li><a href="portfolio.html">portfolio.</a></li>


Also li can't be a child of section, it can only be a child element of ul or ol.

CheezItMan · 2018-09-21T16:38:38Z

styles/about.css

+  color:#eee;
+}
+
+.background:before{


Nice parallax effect.

CheezItMan · 2018-09-21T16:39:53Z

styles/blog.css

+  background-image: url("https://i.imgur.com/LSpa1mM.jpg");
+}
+
+.container {


Notice you have the this style repeated in multiple files. Not exactly DRY.

CheezItMan · 2018-09-21T16:40:20Z

styles/blog.css

+  grid-template-rows: 1fr 1fr 4fr 1fr
+}
+
+.header {


You also have a lot of these styles repeated in multiple files

CheezItMan · 2018-09-21T16:41:48Z

styles/styles(port).css

+}
+
+body {
+  background-image: url("https://i.imgur.com/LSpa1mM.jpg");


in CSS you use single quotes, not double.

CheezItMan · 2018-09-21T16:42:07Z

styles/normalize(port).css

+ */
+
+button,
+[type="button"],


In CSS use single quotes, not double quotes.

sheland added 4 commits September 16, 2018 18:23

created html and css files

3123dd5

index

0aa5091

complete

f8f007a

complete

ddac19f

CheezItMan reviewed Sep 21, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shelan's portfolio #21

Shelan's portfolio #21

sheland commented Sep 17, 2018

CheezItMan commented Sep 21, 2018

CheezItMan Sep 21, 2018

CheezItMan Sep 21, 2018

CheezItMan Sep 21, 2018

CheezItMan Sep 21, 2018

CheezItMan Sep 21, 2018

CheezItMan Sep 21, 2018

CheezItMan Sep 21, 2018

CheezItMan Sep 21, 2018

CheezItMan Sep 21, 2018

CheezItMan Sep 21, 2018

Shelan's portfolio #21

Are you sure you want to change the base?

Shelan's portfolio #21

Conversation

sheland commented Sep 17, 2018

Personal Portfolio Site

Comprehension Questions

CheezItMan commented Sep 21, 2018

Personal Portfolio Site

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment