personal site by Jessie

[jessiezhang2017]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	add alt attribute to img
Why is it important to consider and use semantic HTML?	it will give code readers more information about the code.
How did you decide to structure your CSS?	I used one general css file for common things for all html files, then each html has its only css file.
What was the most challenging piece of this assignment?	hard to decide the html structures.
Describe one area that you gained more clarity on when completing this assignment	flex box vs grid
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?	https://github.com/jessiezhang2017/grocery-store
Overall	it is not easy to make the website show the result of the css code.

[CheezItMan]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	Reasonable number of commits and mostly good commit messages (adjust, isn't a good commit message).
Answered comprehension questions	Check, that wasn't a link to github pages. You can see documentation on github pages here
Page fully loads	Check
No broken links (regular or images)	LOTS of broken links, you used absolute paths.
Includes at least 4 pages and styling	Check
HTML
Uses the high-level tags for organization: header, footer, main	You are using good high-level tags
Appropriately using semantic tags: section, article, etc.	Check
All images include alternate text	Check
CSS
Using class and ID names in style declarations	Check, good use of classes and grid templates
Style declarations are DRY	You have a lot of replicated rules in your CSS. Take a look at your .site_content styling.
Overall	Not bad, you did use absolute paths for your links, but you did make good use of flexbox & grid. Another thing to verify is that you put light-colored text on dark backgrounds or dark text on light backgrounds. Otherwise it's hard to read. You did meet all the learning goals for the project. Well done.

[CheezItMan]

a black background with dark blue text makes this very hard to read.

[CheezItMan]

These are absolute links. Instead of the full file path you should use a relative path. like:

    <a href="index.html">Home</a>

[CheezItMan]

Misspelled section element

[CheezItMan]

One thing to note on this page is that it doesn't look great on smaller screens.