Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal portfolio - Divya #27

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

Naltrexone
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Nothing that was impeding the code from running.
Why is it important to consider and use semantic HTML? To make sure that global standards are being met and for accessibility and readability across platforms.
How did you decide to structure your CSS? I used quite a bit of flex-box in my styling. Colors and pictures made the pages more visually appealing.
What was the most challenging piece of this assignment? Getting the syntax right!
Describe one area that you gained more clarity on when completing this assignment
Optional Learnt to better organize and finish a project like this.
Did you deploy to GitHub Pages? If so, what is the URL to your website? Yes, I did. https://github.com/Naltrexone
Overall Better understanding of the bigger picture(like the layout), and also the smaller details of styling.

@Naltrexone Naltrexone changed the title Project portfolio requirements completed-working copy Personal portfolio - Divya Sep 17, 2018
@dHelmgren
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage I would like to see much more frequent commits. It can be challenging to build this into your workflow when starting with a new language or style of programming, but that's also when it's most useful to have a record of what you did and how you did it.
Answered comprehension questions yep!
Page fully loads Yes, but your index.html doesn't link to the rest of your website, but each page loads correctly.
No broken links (regular or images) All images work, but there are no links between pages.
Includes at least 4 pages and styling Yes!
HTML
Uses the high-level tags for organization: header, footer, main You're using head and body, but no high level tags in your html besides the footer in index.html
Appropriately using semantic tags: section, article, etc. you use section in index.html, but I don't see semantic html in other parts of your project.
All images include alternate text no, your images in about.html aren't given alt text.
CSS You had 4 css files, all named styles in the same folder as your html files, which went counter to our directions.
Using class and ID names in style declarations I see that you used one class, but no ID names
Style declarations are DRY Yes, though the selections are limited.
Overall I think there were some missed concepts for you in your html and css learning. Moving forward, my hope is that you can ask us as instructors and your peers for advice on using semantic html, and get a some work using relative paths to link pages, images and css files together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants