Danielle Metzner - Personal Website

[danimetz]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	My Sections didn't have headers. Didn't know if this is always required for a section.
Why is it important to consider and use semantic HTML?	The sections are labelled with appropriate sections
How did you decide to structure your CSS?	I used a new CSS for each page. Looking back I would probably do one CSS for footers and navigators.
What was the most challenging piece of this assignment?	Having enough time to make it look the way that I want it to look.
Describe one area that you gained more clarity on when completing this assignment	Structuring the CSS files
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?	No
Overall

[dHelmgren]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	I would like to see much more frequent commits. It can be challenging to build this into your workflow when starting with a new language or style of programming, but that's also when it's most useful to have a record of what you did and how you did it.
Answered comprehension questions	I want to call out that semantic html is also useful for helping other people navigate you html, and useful for screen readers or google crawlers to make sense of your website.
Page fully loads	most pages do, but your contact link is broken, and one of your images in mountain biking has a broken link.
No broken links (regular or images)	One broken image, one broken link.
Includes at least 4 pages and styling	I can only get to three. :(
HTML
Uses the high-level tags for organization: header, footer, main	Yes!
Appropriately using semantic tags: section, article, etc.	Yes, but I think you used section at times when article may have made more sense.
All images include alternate text	No.
CSS
Using class and ID names in style declarations	I saw classes but no ID's?
Style declarations are DRY	Besides the fact that you didn't use a main.css to encapsulate CSS that applied to more than one page.
Overall	I think this website is well on track. You have a few errors that stand out, particularly some broken links that wou;d be pretty easy to fix.

For this project, the instructors are giving a spot-check review. If you’d like a more in-depth review, please reach out to me!

[dHelmgren]

I found the image, but it looks like my computer care more about the case of the file extension. the file you saved has the extension ".JPG".

[dHelmgren]

No alt text. :'(

[dHelmgren]

You use these fonts a lot, and if you moved them into a main.css you'd only have to load them once.