Portfolio - Hannah

[hertweckhr1]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	I had forgotten to put alt attributes for many of my pictures, so it was helpful to point them out.
Why is it important to consider and use semantic HTML?	It is important to consider use semantic HTML when considering the the difference of in-line characters. Also it is helpful in organizing structure and additionally later in CSS styling.
How did you decide to structure your CSS?	I had one main style.css that spanned every page. I then created a style sheet for each page and organized it by running down the html format.
What was the most challenging piece of this assignment?	Timing was the hardest, I wanted to spend a lot more time on it, but I had much more homework to complete. One particular section I had a hard time with was figuring out how to overlap sections in the homepage.
Describe one area that you gained more clarity on when completing this assignment	I gained more clarity on majority of items we learned over the week because of practice. Specifically I gained more experience with grid.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?	I did deploy to github places. My url was https://github.com/hertweckhr1/projectname.
Overall

[dHelmgren]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	I would like to see much more frequent commits. It can be challenging to build this into your workflow when starting with a new language or style of programming, but that's also when it's most useful to have a record of what you did and how you did it.
Answered comprehension questions	I want to highlight how semantic html also helps programs like screen readers and Google crawlers navigate your site!
Page fully loads	Yes
No broken links (regular or images)	Yes
Includes at least 4 pages and styling	Yes
HTML
Uses the high-level tags for organization: header, footer, main	Yes
Appropriately using semantic tags: section, article, etc.	This could be better. You tend to over use section when other tags might be a better semantic fit.
All images include alternate text	I can't seem to find the alternate text for the images on your project labels!
CSS
Using class and ID names in style declarations	yes!
Style declarations are DRY	Could be a bit better, see comments in blog.css
Overall	Good work overall! It's clear to me that the learning goals for this assignment were met.

For this project, the instructors are giving a spot-check review, looking for big patterns rather than going through your code line-by-line. If you’d like a more in-depth review, please reach out to me!

[dHelmgren]

Couldn't the styles be "odd-blog" and "even-blog" instead? That way you only have to change 2 styles instead of 5.

[dHelmgren]

Section is a good tag, but I think article might be more specific. Do you agree?