Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leanne Rivera - nodes #38

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Conversation

leannerivera
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? forgot some alts
Why is it important to consider and use semantic HTML? for css styling. it identifies everything so you can style them much easier
How did you decide to structure your CSS? i have a few stylesheets for different pages. two pages use the same stylesheet
What was the most challenging piece of this assignment? making everything look appealing and nice.
Describe one area that you gained more clarity on when completing this assignment css animations and css in general
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? no.
Overall

@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Very good number of commits and good commit messages
Answered comprehension questions Check, Semantic tags also provide meaning for their contents.
Page fully loads Check
No broken links (regular or images) Check, some links unfinished, likes to projects.
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main Check
Appropriately using semantic tags: section, article, etc. Check, good use of semantic tags.
All images include alternate text Check
CSS
Using class and ID names in style declarations Good use of classes
Style declarations are DRY You have some repeated rules in your CSS. It could be dried up a bit.
Overall Well done, I like the CSS animations. You hit all the learning goals.

</p>
</section>
</header>
<main>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off a bit

.hideme {
overflow: hidden;
max-height: 0;
transition: max-height .6s ease;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS Animations neat!

color: #B0D0D3;
padding: 0 2%;
text-shadow: 0 0 2px #ffffff, 0 0 15px #70ffff, 0 0 20px #46fdff, 0 0 40px #46fdff;
animation: buzzzz 1s infinite linear;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Animations, neat

<sub> a curated selection of projects done while at ada developers academy </sub>
<ul>
<li>
<a href='#'> random menu </a> ⌸

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these links are unfinished


a {
text-decoration: none;
color: white;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of repeated rules like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants