Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laura's personal website #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lauracodecreations
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, I had more than one main, and no alt attribute in images
Why is it important to consider and use semantic HTML? To help the reader understand more about how my page works and helped them find information easily.
How did you decide to structure your CSS? I used grouping and class selectors to format specific parts of my website.
What was the most challenging piece of this assignment? It was formatting the page as I wanted it to. It can be easy to focus in a very specific detail instead of looking at the overall picture.
Describe one area that you gained more clarity on when completing this assignment
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Not very many commits, you're doing too much in too few commits
Answered comprehension questions Check, except describing any areas where you gained more clarity
Page fully loads Check
No broken links (regular or images) One broken link, see my inline notes
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main Check
Appropriately using semantic tags: section, article, etc. Check
All images include alternate text Check (online one)
CSS
Using class and ID names in style declarations Good use of some classes
Style declarations are DRY Yes , but fairly small css file
Overall You did everything required, although it would have been better to experiment a bit more and maybe use more layout techniques than flexbox. That said, you have hit all the learning goals. Nice, simple site with (almost) everything working.

<body>
<nav>
<ul class="navigation">
<li><a href="portafolio.html"> Portfolio </a> </li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken link

<head>
<meta charset="utf-8">
<title>About</title>
<LINK REL=StyleSheet HREF="stylesheets/normalize.css" TYPE="text/css" MEDIA=screen>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

html elements should not be capitalized. You should also not capitalize attributes either.

}

header {
background-image: url("../images/mountain.jpg");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In CSS you should use single quotes

.navigation {
display: flex;
justify-content: space-around;
align-items: right;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't align items right.

}

footer{
padding: 1rem 10;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have a unit for the padding 10 value.

padding: 1rem 10;
background-color: rgba(86, 162, 159, 1);
color: white;
font-size: 15;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your font should have a unit size like pt or rem etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants