-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laura's personal website #40
base: master
Are you sure you want to change the base?
Conversation
Personal Portfolio SiteWhat We're Looking For
|
<body> | ||
<nav> | ||
<ul class="navigation"> | ||
<li><a href="portafolio.html"> Portfolio </a> </li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken link
<head> | ||
<meta charset="utf-8"> | ||
<title>About</title> | ||
<LINK REL=StyleSheet HREF="stylesheets/normalize.css" TYPE="text/css" MEDIA=screen> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
html elements should not be capitalized. You should also not capitalize attributes either.
} | ||
|
||
header { | ||
background-image: url("../images/mountain.jpg"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In CSS you should use single quotes
.navigation { | ||
display: flex; | ||
justify-content: space-around; | ||
align-items: right; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't align items right.
} | ||
|
||
footer{ | ||
padding: 1rem 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to have a unit for the padding 10 value.
padding: 1rem 10; | ||
background-color: rgba(86, 162, 159, 1); | ||
color: white; | ||
font-size: 15; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your font should have a unit size like pt
or rem
etc.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions