Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goeun Edges Personal Portfolio #42

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

goeunpark
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? sometimes it said I didn't have closing tags when I did. I think it might be because of the way I ordered tags. Important lesson: nest things properly!!
Why is it important to consider and use semantic HTML? MAKE THINGS ACCESSIBLE and maybe one day lightyears from now css might also fall apart and we want our content to be coherent without depending on styling.
How did you decide to structure your CSS? I worked with css grid to create 2 visible columns.
What was the most challenging piece of this assignment? I never figured out how to make the footer centered AND stick to the bottom of the page.
Describe one area that you gained more clarity on when completing this assignment i like css + excited to get better at it. it's easier to style after creating the initial style sheet.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? lol no
Overall it was a good learning experience!! did feel a bit firehosed here and there but now i feel p good about searching for stuff and using resources around this on my own

@tildeee
Copy link

tildeee commented Sep 30, 2018

For this project, the instructors are giving a spot-check review. If you’d like a more in-depth review, please reach out to your instructor!

My review:
What a lovely site, Goeun! It hits all of the requirements, and it looks really nice and soothing. Great work! Also, your site gave me joy! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants